Skip to content

Commit

Permalink
[Fix] In IE 6, window.external makes Object.keys throw.
Browse files Browse the repository at this point in the history
  • Loading branch information
ljharb committed Dec 4, 2015
1 parent 649a59b commit 568c3e3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion es5-shim.js
Original file line number Diff line number Diff line change
Expand Up @@ -919,7 +919,8 @@ var blacklistedKeys = {
$frames: true,
$frameElement: true,
$webkitIndexedDB: true,
$webkitStorageInfo: true
$webkitStorageInfo: true,
$external: true
};
var hasAutomationEqualityBug = (function () {
/* globals window */
Expand Down
2 changes: 1 addition & 1 deletion tests/spec/s-object.js
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ describe('Object', function () {
ifWindowIt('can serialize all objects on the `window`', function () {
var has = Object.prototype.hasOwnProperty;
var windowItemKeys, exception;
var blacklistedKeys = ['window', 'console', 'parent', 'self', 'frame', 'frames', 'frameElement'];
var blacklistedKeys = ['window', 'console', 'parent', 'self', 'frame', 'frames', 'frameElement', 'external'];
if (supportsDescriptors) {
Object.defineProperty(window, 'thrower', { configurable: true, get: function () { throw new RangeError('thrower!'); } });
}
Expand Down

0 comments on commit 568c3e3

Please sign in to comment.