Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action failing even without errors reported by Vale #48

Open
fivetran-joliveira opened this issue Nov 23, 2021 · 2 comments
Open

Action failing even without errors reported by Vale #48

fivetran-joliveira opened this issue Nov 23, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@fivetran-joliveira
Copy link

fivetran-joliveira commented Nov 23, 2021

I'm facing a scenario on which vale-action is failing the lint step thus never reporting the detailed output of suggestions and warnings.

While attempting to create a use case to reproduce the issue, I found the exact same issue on this repository, on actions executed on the 25th of October 2021:

  1. Failed, no errors reported by Vale
Vale: Found 10 suggestion(s), 13 warning(s), and 0 error(s).

https://github.com/errata-ai/vale-action/runs/3991245834?check_suite_focus=true

  1. Succeeded, same commit hash as previous action that failed, no errors reported by Vale
Vale: Found 10 suggestion(s), 13 warning(s), and 0 error(s).

https://github.com/errata-ai/vale-action/runs/3991248374?check_suite_focus=true

Questions:

  1. What's the difference between those two action runs?
  2. Why did the first one failed?
  3. Why did the second one passed?
@themr0c
Copy link
Contributor

themr0c commented Feb 11, 2022

I have a question that is probably related: the action is failing when there are no warnings or errors.

Expected behavior: fail on errors only, like the vale CLI does.

Run errata-ai/[email protected]
  with:
    files: all
    onlyAnnotateModifiedLines: false
    debug: false
  env:
    GITHUB_TOKEN: ***
/usr/bin/docker run --name db2d7df5c69d0603642809360383fc35d20ff_6f7810 --label 7db2d7 --workdir /github/workspace --rm -e GITHUB_TOKEN -e INPUT_STYLES -e INPUT_CONFIG -e INPUT_FILES -e INPUT_ONLYANNOTATEMODIFIEDLINES -e INPUT_DEBUG -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_RETENTION_DAYS -e GITHUB_RUN_ATTEMPT -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_SERVER_URL -e GITHUB_API_URL -e GITHUB_GRAPHQL_URL -e GITHUB_REF_NAME -e GITHUB_REF_PROTECTED -e GITHUB_REF_TYPE -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e GITHUB_ACTION_REPOSITORY -e GITHUB_ACTION_REF -e GITHUB_PATH -e GITHUB_ENV -e RUNNER_OS -e RUNNER_ARCH -e RUNNER_NAME -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/vale-at-red-hat/vale-at-red-hat":"/github/workspace" 7db2d7:df5c69d0603642809360383fc35d20ff  "" "" "all" "false" "false"
Vale: Found 64 suggestion(s), 0 warning(s), and 0 error(s).

@jdkato jdkato added the bug Something isn't working label Feb 14, 2022
@jdkato
Copy link
Member

jdkato commented Feb 23, 2022

Have you been able to reproduce this consistently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants