feat: Emails are stored in lowercase #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/auth/service/auth.service.ts
Outdated
| @@ -131,6 +131,7 @@ export class AuthService { | |||
| } | |||
|
|
|||
| async resendEmailVerificationCode(email: string) { | |||
| email = email.toLowerCase(); | |||
There was a problem hiding this comment.
Could we just use the transform property from the DTO every time we receive an email (maybe except for linkedin auth where we can just pass it as a lowercased string from the controller). This way we don't have to modify a property in place
There was a problem hiding this comment.
I think I'll just add a LowercaseEmail class with just the email property. That should do it.
rajdip-b
force-pushed
the
feat/email-lowercase
branch
from
8347a96 to
a65b7de
Compare
hsb1007
added a commit
that referenced
this pull request
May 30, 2024
* chore(ci): Made pipeline fixes (#60) * Adding PR title and es lint, prettier, unit test and e2e test checks * Adding commands based on package.json * added husky * order checks * folder updates * folder updates * eslint check * replaced * Add pnpm * refactored installation for pnpm * push diff validate pr yml * deleted commitlintrc file * added makefile * update working directory of ci * update .gitignore * update ci * update ci --------- Co-authored-by: Bhavya Jain <[email protected]> Co-authored-by: Ben <[email protected]> * improve workflow * fixing pr title validation identation issue * update readme (#62) * test(api): Added cleanup test to user module (#61) * added afterALl in user test * update CI * Update README.md * Update README.md * added redis (#63) * refactor: Moved items of backend folder to root (#65) * refactored backend folder * fixed tests * fixed tests * fix: Migrate to ioredis package (#70) * migrate to ioredis * update lockfile * fixed tests * update CI workflow * Update README.md * Update README-backend.md * feat: write-review-page (#71) * Add joined at date for searched user * Update user search query to respect respect http standards * Enable cors * minor fixes * Correct relations * Check if users are connected when doing an user search * fix db structure * fix namings * feat: auth flow changes (#73) * Add joined at date for searched user * Update user search query to respect respect http standards * Enable cors * minor fixes * Correct relations * Check if users are connected when doing an user search * fix db structure * fix namings * Use passwordless signup * Return props needed for signin redirection * feat: Added feature to search by social profile (#77) * added feature to search by social profile * add linkedin profile fetching functionality * finishing touches * delete user controller test file * fixed inconsistencies in e2e tests * made search user endpoint public * feat: Emails are stored in lowercase (#82) * feat: Emails are stored in lowercase * organized code * fix: dashboard various fixes (#78) * Add joined at date for searched user * Update user search query to respect respect http standards * Correct relations * Check if users are connected when doing an user search * fix db structure * Fix: is connection should be true when userId is in the followers * Do not use mutler for uploading profile pics * Context: React native web sends base64 images that cannot be parsed by mutler * update review properties * add get user endpoint * use headline insted of jobtitle * remove console logs * remove console log * Move reviwes in dedicated controller. * Rename ratings to reviews * Use ratings only for professionalism/communication/reliability * Create reviews controller and service * Remove route with */self. * enable swagger plugin * review db structure changes: * change id from int to string * add state * add favorite review model * Add ability to like/unlike reviews and review state * add ability to modify and update own review * feat: add connections controller and move specific endpoints from user controller here * fix: review annonymous property * fix: add isEmailVerified to connection * fix rebase errors * Move search by profile url in connections. * Add authType property on connectionDto * remove jobTitle property. Use headline everywhere * Return transformed user when social account is already existen * add logging * fix reviews issues * rename dto folder * rename methods * make only one DB query for craeting a connection * change DTO folder to a random name (because gh is not case sensitive and doesn't see lowering the case of the file as an actual change) * rename dto folder * squash migrations * fix tests * feat: implement user settings endpoints (#84) * feat: user profile (#85) * fix: Docker builds were not running due to module errors (#86) * feat: implement push notifications (#87) * feat: implement push notifications * fix tests --------- Co-authored-by: Rajdip Bhattacharya <[email protected]> Co-authored-by: Bhavya Jain <[email protected]> Co-authored-by: Ben <[email protected]> Co-authored-by: Adelina Enache <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81