Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wallpaper image size #203

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

C0D3-M4513R
Copy link

If the image res was higher than the desktop res, only part of the image would be displayed.

If the image res was higher than the desktop res, only part of the image would be displayed.
@C0D3-M4513R C0D3-M4513R marked this pull request as draft February 16, 2021 19:36
If the image res was higher than the desktop res, only part of the image would be displayed.
This would only occur on restart, but this fixes this little loophole.
@C0D3-M4513R C0D3-M4513R marked this pull request as ready for review March 1, 2021 13:14
@Bad3r
Copy link

Bad3r commented Apr 30, 2021

Is there a way to make it detect vertical monitors and adapt the wallpaper settings?
I implemented your changes and it works great except for vertical monitors.
Example:
vertical monitor

@C0D3-M4513R
Copy link
Author

Is there a way to make it detect vertical monitors and adapt the wallpaper settings?
I implemented your changes and it works great except for vertical monitors.
Example:
vertical monitor

It looks like the image is only stretched. I this config can't and will never adept aspect ratio. If it would, it would most likely pick the wrong part of the picture.
To fix this, I would suggest using a vertical wallpaper (preferably with the correct aspect ratio), rather than using a horizontal wallpaper
If I think about it more closely, it is probably a feature somewhere, because when there are only small differences in aspect ratio, it will fix this. Not for something like this.

@Bad3r
Copy link

Bad3r commented Apr 30, 2021

I see thanks for the explanation and for your pull requests.
hopefully they get merged soon

@C0D3-M4513R
Copy link
Author

C0D3-M4513R commented Apr 30, 2021

What this pr does, is to ignore the aspect ratio of the picture, because if you have higher res pictures on smaller monitors, it cropps.
That is in my eyes not expected.
So I have done this.
Use a picture with the correct aspect ratio.
This is intended. This is a FEATURE.

As for this pr getting merged soon:
I think, it won't get merged for a few more months, since the author is probably not active anymore, and/or has abandoned this project.

@ankkax
Copy link

ankkax commented Sep 22, 2021

Is there a way to make it detect vertical monitors and adapt the wallpaper settings?
I implemented your changes and it works great except for vertical monitors.
Example:
vertical monitor

Sorry for offtopic question, but how you got linear themes bottom panel to show up? it doesn't work for me all rest of the themes works fine.

@C0D3-M4513R
Copy link
Author

@ankkax check #202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants