Idempotent deterministic build #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The paths for dependencies in the generated dependency Makefiles are removed when using the +deterministic erlc option. This makes subsequent builds fail because the dependency Makefile is read. Adding the -MP erlc option to generate phony targets when building deterministically enables several subsequent builds. Fixes erlyaws#465
vinoski
approved these changes
Jul 25, 2023
vinoski
approved these changes
Jul 25, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add phony targets for deps when building deterministically
The paths for dependencies in the generated dependency Makefiles are
removed when using the +deterministic erlc option. This makes subsequent
builds fail because the dependency Makefile is read.
Adding the -MP erlc option to generate phony targets when building
deterministically enables several subsequent builds.
Fixes Fail when make install and deterministic build is enabled #465
Add smoke test to PR for deterministic build