Return HTTP 400 or 411 if Content-Length is invalid or empty #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etnt
reviewed
Nov 14, 2022
avtobiff
force-pushed
the
content-length-values
branch
2 times, most recently
from
067f6a4
to
219b35c
Compare
|
Is there any problem with this with |
|
I'll check with chunked transfer and POST. |
Return HTTP 400 if Content-Length header is invalid. The Content-Length header is defined to be an integer 0 or greater. See RFC 9110 Section 8.6. Content-Length. Return HTTP 411 if Content-Length is empty for POST, if Transfer-Encoding is not set. If however Transfer-Encoding is used for POST, Content-Length is ignored. See RFC 9112 Section 6.1 Transfer-Encoding. This improves the previous behaviour when Content-Length is not an integer where Yaws immediately cut the connection. It is not totally clearly defined what to do when Content-Length is invalid, but responding with HTTP 400 Bad Request at least notifies the user of their error. One implementation detail to note is that all headers needs to be collected in order to know if Transfer-Encoding is set, if it is set Content-Lenght is ignored. However, if Transfer-Encoding is not set, the normal error handling for Content-Length is performed. This means that the report of multiple content-length headers error is deferred to when all headers are collected..
avtobiff
force-pushed
the
content-length-values
branch
from
219b35c
to
a8a9765
Compare
|
Finally got time to rework this. It needed some changes to take It should be ready for merge now. |
|
I merged thisto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content-Length is defined to be an integer 0 or greater.
The current behaviour when Content-Length is not an integer is that Yaws immediately cuts the connection.
It is not totally clearly defined what to do when Content-Length is invalid, but responding with HTTP 400 Bad Request at least notifies the user of their error.
If POST is used and Content-Length is empty, respond with HTTP 411 Length Required.