Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rebar3 and Erlang/OTP compatibility list #2918

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Add Rebar3 and Erlang/OTP compatibility list #2918

merged 1 commit into from
Nov 1, 2024

Conversation

kianmeng
Copy link
Contributor

Resolves #2903

@kianmeng kianmeng mentioned this pull request Sep 25, 2024
Closed
@kianmeng kianmeng force-pushed the add-rebar3-otp-compatibility-table branch from 1568695 to d83a990 Compare September 25, 2024 16:29
paulo-ferraz-oliveira
paulo-ferraz-oliveira reviewed Sep 25, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
paulo-ferraz-oliveira
paulo-ferraz-oliveira reviewed Sep 25, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
paulo-ferraz-oliveira
paulo-ferraz-oliveira reviewed Sep 25, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@paulo-ferraz-oliveira
Copy link
Contributor

erlang@27, or simply erlang, is already out for Homebrew. I'm not sure if that's what's causing the CI issue.

@ferd
Copy link
Collaborator

ferd commented Sep 26, 2024

erlang@27, or simply erlang, is already out for Homebrew. I'm not sure if that's what's causing the CI issue.

It's been hard-coded, we should be able to remove that @26 and let the macos tests pass now

rebar3/.github/workflows/main.yml

Lines 56 to 57 in 29ccddb

# fall back to OTP-26 since OTP 27.0 doesn't build on homebrew due to manpages issues
run: brew install erlang@26

@kianmeng @paulo-ferraz-oliveira
Add Rebar3 and Erlang/OTP compatibility list
8e08292 
Resolves erlang#2903 and bump Erlang
OTP version for macOS and GitHub actions.

Co-authored-by: Paulo F. Oliveira <[email protected]>
@kianmeng kianmeng force-pushed the add-rebar3-otp-compatibility-table branch from d392e6e to 8e08292 Compare November 1, 2024 10:14
@kianmeng
Copy link
Contributor Author

kianmeng commented Nov 1, 2024

@paulo-ferraz-oliveira @ferd I managed to get CI to pass, and let's get this merge?

@ferd ferd merged commit c8811d1 into erlang:main Nov 1, 2024
6 checks passed
@kianmeng
Copy link
Contributor Author

kianmeng commented Nov 2, 2024

🥳 🥳 🥳 🥳 🥳

vkatsuba
vkatsuba reviewed Nov 2, 2024
View reviewed changes
Copy link
Contributor

@vkatsuba vkatsuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very useful info. I suppose it will be also nice to have some command in rebar for print supported versions.

@paulo-ferraz-oliveira
Copy link
Contributor

This is very useful info. I suppose it will be also nice to have some command in rebar for print supported versions.

If this is ever considered we could then use it in the generation of the README to avoid two sources of truth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkatsuba vkatsuba vkatsuba left review comments

@ferd ferd ferd approved these changes

@paulo-ferraz-oliveira paulo-ferraz-oliveira Awaiting requested review from paulo-ferraz-oliveira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compatibility between Rebar3 and Erlang/OTP
4 participants
@kianmeng @paulo-ferraz-oliveira @ferd @vkatsuba