Made rebar_utils:filtermap/2 to call directly lists:filtermap/2
#2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on a regression in R27. |
* local implementation introduced by a4d4c6c * introduced to work around releases prior R16 not having `lists:filtermap/2` [1] * CI/CD nows runs wtih R25 to R27. [1] https://www.erlang.org/doc/apps/stdlib/lists.html#filtermap/2 Signed-off-by: Ariel Otilibili <[email protected]>
|
PR is ready; couldn't reproduce the bug. The action failed on # rebar3 ct --dir apps/rebar/test/ --suite rebar_xref_SUITE.erl
===> Verifying dependencies...
===> Analyzing applications...
===> Compiling cth_readable
===> Compiling bbmustache
===> Compiling cf
===> Compiling erlware_commons
===> Compiling getopt
===> Compiling eunit_formatters
===> Compiling providers
===> Compiling ssl_verify_fun
===> Compiling relx
===> Compiling certifi
===> Compiling rebar
===> Running Common Test suites...
%%% rebar_xref_SUITE: ....
All 4 tests passed.
# git branch
* filtermap
main |
|
Complete debug on my system: # rebar3 --version
rebar 3.23.0 on Erlang/OTP 27 Erts 15.0
# rebar3 ct
===> Verifying dependencies...
===> Analyzing applications...
===> Compiling cth_readable
===> Compiling bbmustache
===> Compiling cf
===> Compiling erlware_commons
===> Compiling getopt
===> Compiling eunit_formatters
===> Compiling providers
===> Compiling ssl_verify_fun
===> Compiling relx
===> Compiling certifi
===> Compiling rebar
===> Running Common Test suites...
%%% rebar_alias_SUITE: .........
%%% rebar_as_SUITE: ...........
%%% rebar_compile_SUITE: ...................................................................................
%%% rebar_compile_SUITE ==> always_recompile_when_erl_compiler_options_set: SKIPPED
%%% rebar_compile_SUITE ==> {tc_user_skip,"compile:env_compiler_options/0 available"}
.....
%%% rebar_compiler_dag_SUITE: ...........
%%% rebar_compiler_epp_SUITE: ......
%%% rebar_compiler_format_SUITE: ..
%%% rebar_completion_SUITE: ..
%%% rebar_completion_SUITE ==> check_zsh: SKIPPED
%%% rebar_completion_SUITE ==> {tc_user_skip,"zsh not found"}
%%% rebar_cover_SUITE: .............
%%% rebar_ct_SUITE: .........................................................
%%% rebar_deps_SUITE: ..............................
%%% rebar_dialyzer_SUITE: ..............
%%% rebar_dir_SUITE: .......................
%%% rebar_disable_app_SUITE: .
%%% rebar_discover_SUITE: ....
%%% rebar_dist_utils_SUITE: ....
%%% rebar_edoc_SUITE: ...
%%% rebar_escriptize_SUITE: .....
%%% rebar_eunit_SUITE: .........................................
%%% rebar_file_utils_SUITE: ......................
%%% rebar_hooks_SUITE: .............
%%% rebar_install_deps_SUITE: .......................................
%%% rebar_lock_SUITE: ....
%%% rebar_manifest_SUITE: ....
%%% rebar_namespace_SUITE: ...............
%%% rebar_new_SUITE: .......
%%% rebar_opts_parser_SUITE: ..
%%% rebar_parallel_SUITE: ....
%%% rebar_paths_SUITE: ....
%%% rebar_pkg_SUITE: ...........
%%% rebar_pkg_alias_SUITE: ....
%%% rebar_pkg_repos_SUITE: ..............
%%% rebar_plugins_SUITE: .............
%%% rebar_profiles_SUITE: .........................
%%% rebar_release_SUITE: ............
%%% rebar_resource_SUITE: ...
%%% rebar_src_dirs_SUITE: ............
%%% rebar_templater_SUITE: ..
%%% rebar_unlock_SUITE: ....
%%% rebar_upgrade_SUITE: ..............................................................
%%% rebar_uri_SUITE: ..
%%% rebar_utils_SUITE: .........................../usr/lib/erlang/erts-15.0/bin/inet_gethost[849893]: WARNING:Timeout waiting for child process to die, ignoring child (pid = 849894).
/usr/lib/erlang/erts-15.0/bin/inet_gethost[849893]: WARNING:Timeout waiting for child process to die, ignoring child (pid = 852430).
/usr/lib/erlang/erts-15.0/bin/inet_gethost[849893]: WARNING:Timeout waiting for child process to die, ignoring child (pid = 852446).
/usr/lib/erlang/erts-15.0/bin/inet_gethost[849893]: WARNING:Timeout waiting for child process to die, ignoring child (pid = 852463).
/usr/lib/erlang/erts-15.0/bin/inet_gethost[849893]: WARNING:Timeout waiting for child process to die, ignoring child (pid = 852481).
/usr/lib/erlang/erts-15.0/bin/inet_gethost[849893]: WARNING:Timeout waiting for child process to die, ignoring child (pid = 852498).
/usr/lib/erlang/erts-15.0/bin/inet_gethost[849893]: WARNING:Timeout waiting for child process to die, ignoring child (pid = 852515).
/usr/lib/erlang/erts-15.0/bin/inet_gethost[849893]: WARNING:Timeout waiting for child process to die, ignoring child (pid = 852533).
/usr/lib/erlang/erts-15.0/bin/inet_gethost[849893]: WARNING:Timeout waiting for child process to die, ignoring child (pid = 852555).
/usr/lib/erlang/erts-15.0/bin/inet_gethost[849893]: WARNING:Timeout waiting for child process to die, ignoring child (pid = 852572).
/usr/lib/erlang/erts-15.0/bin/inet_gethost[849893]: WARNING:Timeout waiting for child process to die, ignoring child (pid = 852589).
/usr/lib/erlang/erts-15.0/bin/inet_gethost[849893]: WARNING:Timeout waiting for child process to die, ignoring child (pid = 852606).
/usr/lib/erlang/erts-15.0/bin/inet_gethost[849893]: WARNING:Timeout waiting for child process to die, ignoring child (pid = 852623).
/usr/lib/erlang/erts-15.0/bin/inet_gethost[849893]: WARNING:Timeout waiting for child process to die, ignoring child (pid = 852640).
/usr/lib/erlang/erts-15.0/bin/inet_gethost[849893]: WARNING:Timeout waiting for child process to die, ignoring child (pid = 852657).
..
%%% rebar_xref_SUITE: ....
Skipped 2 (2, 0) tests. Passed 635 tests. |
ferd
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lists:filtermap/2.