Implement lazy-read and noshell raw mode #8962
Merged
+1,411
−460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 6 files 303 suites 3h 10m 25s ⏱️ For more details on these failures, see this check. Results for commit 28953ce. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
You can read the new guides here: |
zachallaun
reviewed
Oct 21, 2024
garazdawi
force-pushed
the
lukas/kernel/shell-improvements
branch
from
8e32c5a
to
cd522a8
Compare
garazdawi
added
testing
garazdawi
force-pushed
the
lukas/kernel/shell-improvements
branch
from
4f90535
to
085259c
Compare
garazdawi
added
the
testing
sverker
removed
the
testing
garazdawi
force-pushed
the
lukas/kernel/shell-improvements
branch
from
c70d9fa
to
f321f21
Compare
When running in `-noshell` mode, it is "normal" for programs to not eagerly read from stdin. This commit changes so that we only issue read requests to stdin when `user` has received a read request from the application. This change also makes it so that on Windows we don't have to abort an ongoing read request, which means that we can use ReadFile in non-overlapped mode and thus Unicode will work when reading from stdin in noshell mode on windows.
When an Erlang shell gets EOF it should halt the node, however very often stderr is also closed at the same time which caused the error printing to crash preventing halt to be called.
garazdawi
force-pushed
the
lukas/kernel/shell-improvements
branch
from
28953ce
to
bd2ba03
Compare
This was referenced Oct 30, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a couple of new fetures to how stdin and stdout is handled by Erlang.
All reads from stdin are now done upon request, instead of greedingly reading all data. So it is only when an
io:get_line/2or equivilant is issued by the Erlang program that a read is done. This solves io:get_line/1 cannot read cyrillic input on Windows with -noshell #8113 and also the problem mentioned by Josè here. This change also basically makes the-noinputflag obsolete, as no data will be read from stdin without it being requested.The
noshellmode has been updated to have two "submodes" calledraworcooked, wherecookedis the old default behaviour andrawcan be used to bypass the line editing support of the native terminal. Usingrawmode it is possible to read keystrokes as they happen without the user having to type Enter. Therawmode also does not echo the typed characters to stdout. An example of how to create a tic-tac-toe game using this mechanism is included in the documentation. This solves Getch for OTP26 #8037.There is also a new guide added that shows how to create a custom shell with autocomplete using Erlang's builtin line editor (basically what Elixir, Luerl and other do).