Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public_key: Correct argument order #8839

Merged
merged 1 commit into from
Sep 25, 2024
Merged

public_key: Correct argument order #8839

merged 1 commit into from
Sep 25, 2024

Conversation

IngelaAndin
Copy link
Contributor

closes #8832

@IngelaAndin IngelaAndin self-assigned this Sep 20, 2024
@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Sep 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

CT Test Results

  2 files   17 suites   5m 31s ⏱️
284 tests 282 ✅ 2 💤 0 ❌
300 runs  298 ✅ 2 💤 0 ❌

Results for commit d5af1b3.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin IngelaAndin force-pushed the ingela/public_key/verify_fun_arg_order/OTP-19245 branch from ae0b793 to a620f91 Compare September 22, 2024 18:28
@IngelaAndin IngelaAndin added the testing currently being tested, tag is used by OTP internal CI label Sep 22, 2024
@IngelaAndin IngelaAndin force-pushed the ingela/public_key/verify_fun_arg_order/OTP-19245 branch from a620f91 to db35f9b Compare September 23, 2024 09:46
dgud
dgud approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@dgud dgud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is unfortunate other functions have the other order see, pubkey_cert:validate_signature/6 for example.

@u3s
Copy link
Contributor

u3s commented Sep 23, 2024

how come the related issue wasn't discovered in tests? are we missing some coverage?

@IngelaAndin
Copy link
Contributor Author

@u3s I am a little confused about the reason just now, but I would say that it is mainly because coverage was not as good as it should have been.

@IngelaAndin
Copy link
Contributor Author

@dgud This is just a internal function so maybe we can fix it other way around. I will consider it tomorrow!

@u3s
Copy link
Contributor

u3s commented Sep 23, 2024

@u3s I am a little confused about the reason just now, but I would say that it is mainly because coverage was not as good as it should have been.

Should it be added in this PR?

@IngelaAndin
Copy link
Contributor Author

It is.

@IngelaAndin
Copy link
Contributor Author

@u3s But I am think about possible further test.

@IngelaAndin IngelaAndin force-pushed the ingela/public_key/verify_fun_arg_order/OTP-19245 branch from db35f9b to d5af1b3 Compare September 24, 2024 09:53
@IngelaAndin IngelaAndin merged commit 5622413 into erlang:maint Sep 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@u3s u3s u3s approved these changes

@dgud dgud dgud approved these changes

Assignees

@IngelaAndin IngelaAndin

Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IngelaAndin @u3s @dgud