Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs for ets:select_count and ets:select_delete #8834

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

Maria-12648430
Copy link
Contributor

This PR fixes a typo (a missing "is") in the docs for ets:select_count. I also removed the sentence which basically reads "like select_delete but without deleting", because I think that, while true, it is more confusing than helpful. I also reworded some parts of the description, also for select_delete, for better readability (IMO, that is 😅).

Copy link
Contributor

github-actions bot commented Sep 20, 2024

CT Test Results

    2 files     95 suites   56m 2s ⏱️
2 156 tests 2 108 ✅ 48 💤 0 ❌
2 515 runs  2 465 ✅ 50 💤 0 ❌

Results for commit 07a2ab6.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin IngelaAndin added the team:VM Assigned to OTP team VM label Sep 23, 2024
@sverker sverker changed the base branch from master to maint October 2, 2024 10:36
@sverker sverker changed the base branch from maint to master October 2, 2024 10:37
@sverker
Copy link
Contributor

sverker commented Oct 2, 2024

Looks good.
I recommend rebasing on maint for an earlier release.

@Maria-12648430 Maria-12648430 changed the base branch from master to maint October 2, 2024 11:03
@Maria-12648430 Maria-12648430 changed the base branch from maint to master October 2, 2024 11:03
@Maria-12648430 Maria-12648430 changed the base branch from master to maint October 2, 2024 11:11
@Maria-12648430
Copy link
Contributor Author

Looks good. I recommend rebasing on maint for an earlier release.

Done

@sverker sverker added documentation testing currently being tested, tag is used by OTP internal CI labels Oct 2, 2024
@sverker sverker merged commit 7c44844 into erlang:maint Oct 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants