Adds bubbling core-signal events in addition to element based events #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to make supporting elements, access to the app-router events is needed. Sending core-signal events allows elements that are ignorant of the rest of the application still respond meaningfully to these events. This is needed for elements such as page tracking, comment plug-ins where the provider requires a singleton call, or other sitewide changes based on route changes.
…ment based events
|
For an example of how this can be used: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make supporting elements, access to the app-router events is needed. Sending core-signal events allows elements that are ignorant of the rest of the application still respond meaningfully to these events.
This is needed for elements such as page tracking, comment plug-ins where the provider requires a singleton call, or other sitewide changes based on route changes.