New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kmeans fix #6

Open

ihoromi4 wants to merge 2 commits into eriklindernoren:master from ihoromi4:kmeans-fix

ihoromi4 commented Jun 7, 2023 •

edited

Loading

It seems that KMeans has slightly incorrect code line. It results in computing as much clusters as data points.

Code to reproduce bug:

from sklearn.datasets import make_blobs
from napkin_ml import KMeans

X, y = make_blobs(n_samples=300, centers=3, random_state=1)
kmeans = KMeans()
clusters = kmeans.fit(X, 3)
print(np.unique(clusters))

Result: array([0, 1, 3])
Expected: [0, 1, 2]
Where is the 2nd cluster? Where is the 3rd cluster appeared from?

ihoromi4 added 2 commits

June 7, 2023 16:16


          Update KMeans code

0a12050


          Update KMeans readme

3e8c57f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet