LocalVariableHidesMemberIssue: suppress warning if the variable is in…

…itialized using the member.

ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/Synced/CodeQuality/LocalVariableHidesMemberIssue.cs

@@ -60,6 +60,12 @@ public override void VisitVariableInitializer (VariableInitializer variableIniti
 
 				if (!(ctx.Resolve (variableInitializer) is LocalResolveResult))
 					return;
+				var mre = variableInitializer.Initializer as MemberReferenceExpression;
+				if (mre != null && mre.MemberName == variableInitializer.Name && mre.Target is ThisReferenceExpression) {
+					// Special case: the variable is initialized from the member it is hiding
+					// In this case, the hiding is obviously intentional and we shouldn't show a warning.
+					return;
+				}
                 CheckLocal(variableInitializer, variableInitializer.Name, variableInitializer.NameToken);
 			}
 

ICSharpCode.NRefactory.Tests/CSharp/CodeIssues/LocalVariableHidesMemberIssueTests.cs

@@ -206,5 +206,23 @@ void Method ()
 }";
 			Test<LocalVariableHidesMemberIssue> (input, 0);
 		}
+
+		[Test]
+		public void SuppressIssueIfVariableInitializedFromField ()
+		{
+			var input = @"
+class TestClass
+{
+	int i;
+	
+	void Method ()
+	{
+		int i = this.i;
+	}
+}";
+			// Given the initializer, member hiding is obviously intended in this case;
+			// so we suppress the warning.
+			Test<LocalVariableHidesMemberIssue> (input, 0);
+		}
 	}
 }