Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvovk/updsync #9134

Merged
merged 5 commits into from
Jan 8, 2024
Merged

dvovk/updsync #9134

merged 5 commits into from
Jan 8, 2024

Conversation

dvovk
Copy link
Member

@dvovk dvovk commented Jan 4, 2024

refactored data structure for sync statistics

})

log.Info(fmt.Sprintf("[%s] download finished", logPrefix), "time", time.Since(downloadStartTime).String())
break Loop
} else {
isDiagEnabled := diagnostics.TypeOf(diagnostics.SyncStagesList{}).Enabled()
if isDiagEnabled {
diagnostics.Send(diagnostics.SyncStagesList{Stages: stagesIdsList})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't understand meaning of this line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed check

@dvovk dvovk requested a review from AskAlexSharov January 6, 2024 12:24
})

log.Info(fmt.Sprintf("[%s] download finished", logPrefix), "time", time.Since(downloadStartTime).String())
break Loop
} else {
diagnostics.Send(diagnostics.SyncStagesList{Stages: stagesIdsList})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t understand meaning of this line

@dvovk dvovk merged commit ff92b70 into devel Jan 8, 2024
7 checks passed
@dvovk dvovk deleted the dvovk/updsync branch January 8, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants