Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcdaemon: Don't set miner #13795

Merged
merged 1 commit into from
Feb 13, 2025
Merged

rpcdaemon: Don't set miner #13795

merged 1 commit into from
Feb 13, 2025

Conversation

shohamc1
Copy link
Member

@shohamc1 shohamc1 commented Feb 13, 2025

Fixes incorrect patch for #12690

See: #12690 (comment)

➜  curl --request POST \
  -s --url http://127.0.0.1:8545/ \
  --header 'Content-Type: application/json' \
  --data '{
        "method": "eth_getBlockByHash",
        "params": [
                "latest",
                false
        ],
        "id": 1,
        "jsonrpc": "2.0"
}' | jq '.result.miner'
"0x0000000000000000000000000000000000000000"
➜  curl --request POST \
  -s --url http://127.0.0.1:8545/ \
  --header 'Content-Type: application/json' \
  --data '{
        "method": "eth_getBlockByNumber",
        "params": [
                "latest",
                false
        ],
        "id": 1,
        "jsonrpc": "2.0"
}' | jq '.result.miner'
"0x0000000000000000000000000000000000000000"

@yperbasis yperbasis added this to the 3.0.0-beta2 milestone Feb 13, 2025
@shohamc1 shohamc1 enabled auto-merge (squash) February 13, 2025 12:31
@shohamc1 shohamc1 merged commit 702a0d8 into main Feb 13, 2025
12 of 13 checks passed
@shohamc1 shohamc1 deleted the shohamc1/set-miner branch February 13, 2025 12:41
shohamc1 added a commit that referenced this pull request Feb 13, 2025
Fixes incorrect patch for #12690

See:
#12690 (comment)

```
➜  curl --request POST \
  -s --url http://127.0.0.1:8545/ \
  --header 'Content-Type: application/json' \
  --data '{
        "method": "eth_getBlockByHash",
        "params": [
                "latest",
                false
        ],
        "id": 1,
        "jsonrpc": "2.0"
}' | jq '.result.miner'
"0x0000000000000000000000000000000000000000"
➜  curl --request POST \
  -s --url http://127.0.0.1:8545/ \
  --header 'Content-Type: application/json' \
  --data '{
        "method": "eth_getBlockByNumber",
        "params": [
                "latest",
                false
        ],
        "id": 1,
        "jsonrpc": "2.0"
}' | jq '.result.miner'
"0x0000000000000000000000000000000000000000"
```

(cherry picked from commit 702a0d8)
shohamc1 added a commit that referenced this pull request Feb 13, 2025
Fixes incorrect patch for #12690

See:
#12690 (comment)

```
➜  curl --request POST \
  -s --url http://127.0.0.1:8545/ \
  --header 'Content-Type: application/json' \
  --data '{
        "method": "eth_getBlockByHash",
        "params": [
                "latest",
                false
        ],
        "id": 1,
        "jsonrpc": "2.0"
}' | jq '.result.miner'
"0x0000000000000000000000000000000000000000"
➜  curl --request POST \
  -s --url http://127.0.0.1:8545/ \
  --header 'Content-Type: application/json' \
  --data '{
        "method": "eth_getBlockByNumber",
        "params": [
                "latest",
                false
        ],
        "id": 1,
        "jsonrpc": "2.0"
}' | jq '.result.miner'
"0x0000000000000000000000000000000000000000"
```

(cherry picked from commit 702a0d8)
yperbasis pushed a commit that referenced this pull request Feb 13, 2025
shohamc1 added a commit that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants