Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add to externalcl workflow lighthouse and gnosis support - release 2.61 #13774

Merged
merged 18 commits into from
Feb 13, 2025

Conversation

tosettil-polimi
Copy link
Collaborator

@tosettil-polimi tosettil-polimi commented Feb 12, 2025

This PR updates the QA sync workflow to improve flexibility and expand compatibility with different consensus clients and networks.

Key Changes:

  1. Renamed Job:

    • Changed prysm-minimal-node-sync-from-scratch-testsync-with-externalcl for broader applicability.
  2. Matrix Strategy for Multiple Clients & Chains:

    • Introduced matrix configuration to run tests for:
      • Clients: Lighthouse, Prysm
      • Chains: Mainnet, Gnosis
    • Exclusion: Prysm + Gnosis is not tested.
  3. Client-Specific Setup:

    • Lighthouse and Prysm are now dynamically installed based on the matrix configuration.
    • JWT secret is generated per test run.
  4. Erigon Sync Execution Update:

    • Uses ${{ matrix.chain }} and ${{ matrix.client }} dynamically in test execution and result logging.
  5. Enhanced Logging & Artifacts:

    • Client-specific logs are now uploaded as artifacts.
    • Improved log handling for both Lighthouse and Prysm.
  6. Additional Cleanup Steps:

    • Removed consensus layer data (CL_DATA_DIR) after tests to free up disk space.

Copy link
Member

@mriccobene mriccobene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to install prysm on ${{ github.workspace }}/consensus

@tosettil-polimi tosettil-polimi changed the title Feat/externalcl workflow cleanup Feat/add to externalcl workflow lighthouse and gnosis support Feb 12, 2025
@tosettil-polimi tosettil-polimi enabled auto-merge (squash) February 12, 2025 16:20
@mriccobene mriccobene changed the title Feat/add to externalcl workflow lighthouse and gnosis support Feat/add to externalcl workflow lighthouse and gnosis support - release 2.61 Feb 12, 2025
@tosettil-polimi tosettil-polimi merged commit deaa32d into release/2.61 Feb 13, 2025
7 checks passed
@tosettil-polimi tosettil-polimi deleted the feat/externalcl-workflow-cleanup branch February 13, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants