-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add to externalcl workflow lighthouse and gnosis support - release 2.61 #13774
Merged
tosettil-polimi
merged 18 commits into
release/2.61
from
feat/externalcl-workflow-cleanup
Feb 13, 2025
Merged
Feat/add to externalcl workflow lighthouse and gnosis support - release 2.61 #13774
tosettil-polimi
merged 18 commits into
release/2.61
from
feat/externalcl-workflow-cleanup
Feb 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mriccobene
reviewed
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to install prysm on ${{ github.workspace }}/consensus
mriccobene
approved these changes
Feb 12, 2025
…/erigontech/erigon into feat/externalcl-workflow-cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the QA sync workflow to improve flexibility and expand compatibility with different consensus clients and networks.
Key Changes:
Renamed Job:
prysm-minimal-node-sync-from-scratch-test
→sync-with-externalcl
for broader applicability.Matrix Strategy for Multiple Clients & Chains:
matrix
configuration to run tests for:Client-Specific Setup:
Erigon Sync Execution Update:
${{ matrix.chain }}
and${{ matrix.client }}
dynamically in test execution and result logging.Enhanced Logging & Artifacts:
Additional Cleanup Steps:
CL_DATA_DIR
) after tests to free up disk space.