Hex patricia reader proof #13660
Hex patricia reader proof #13660
Conversation
shotasilagadze
force-pushed
the
hex-patricia-reader-proof
branch
5 times, most recently
from
5fdba10 to
87d0d4b
Compare
shotasilagadze
force-pushed
the
hex-patricia-reader-proof
branch
14 times, most recently
from
04469c7 to
23b8ccb
Compare
| @@ -134,7 +135,7 @@ func NewSharedDomains(tx kv.Tx, logger log.Logger) (*SharedDomains, error) { | |||
| } | |||
|
|
|||
| sd.SetTxNum(0) | |||
| sd.sdCtx = NewSharedDomainsCommitmentContext(sd, commitment.ModeDirect, commitment.VariantHexPatriciaTrie) | |||
| sd.sdCtx = NewSharedDomainsCommitmentContext(sd, commitment.ModeDirect) | |||
There was a problem hiding this comment.
get back option, very soon we will introduce more trie variants
There was a problem hiding this comment.
Ok, but based on that option what do I do? I initialise both of the trie types now. How would I use that option? Or should I leave it unused but as one of the available function parameters?
There was a problem hiding this comment.
That's the part I was asking. I'm not sure which design would be better. So, if I'm initialising both hex patricia tries then when or in which parameter do I initialise bin trie if passed? 🤔
| return rootHash, err | ||
| } | ||
|
|
||
| // data accessing functions should be set when domain is opened/shared context updated | ||
| sdc.patriciaTrie.SetTrace(sdc.sharedDomains.trace) | ||
| sdc.commitmentPatriciaTrie.SetTrace(sdc.sharedDomains.trace) |
There was a problem hiding this comment.
its already CommitmentContext, why introduce commitmentPatriciaTrie?
There was a problem hiding this comment.
To differentiate. So, now I have two trie structures there. One is commitmentPatriciaTrie used for commitment building and another proofPatriciaTrie for just building proofs.
| @@ -1434,9 +1465,6 @@ func _decodeTxBlockNums(v []byte) (txNum, blockNum uint64) { | |||
| // LatestCommitmentState searches for last encoded state for CommitmentContext. | |||
| // Found value does not become current state. | |||
| func (sdc *SharedDomainsCommitmentContext) LatestCommitmentState() (blockNum, txNum uint64, state []byte, err error) { | |||
| if sdc.patriciaTrie.Variant() != commitment.VariantHexPatriciaTrie { | |||
There was a problem hiding this comment.
|| != commitment.VariantHexPatriciaTrieReader`, eg if binary is given. check needed to happen anyway. for now LatestCommitmentState is supported only for hex patricia but with time support will expand.
There was a problem hiding this comment.
The thing is, I never have another type initialised. I only have hex patricia tries as explained above.
shotasilagadze
force-pushed
the
hex-patricia-reader-proof
branch
from
23b8ccb to
c53306d
Compare
Moved proof building into hex patricia READER