polygon/sync: retry ufc on busy response #13640
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a user on discord flagged the following issue (discord link):
Note:
status=5
meansExecutionStatus_Busy
This can happen because there is a possibility that
runPostForkchoiceInBackground
acquires the execution engine semaphore after a successful UFC (line which saysupdate fork choice done in=807.13624ms
) to do pruning. But very shortly after that there is another call to UFC (in this case 7ms after - line which saysupdate fork choice block=67365147
) which then fails with aBusy
response since it can't acquire the semaphore (take byrunPostForkchoiceInBackground
for pruning).This PR fixes this situation by adding retries on
Busy
response when calling UFC. Such a retry already existed when callingInsertBlocks
so this is something that just got missed.