Move IntrinsicGas to fixedgas
#13568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide some motivation for this PR? Was this needed because you need to import this function from inside |
antonis19
reviewed
Jan 27, 2025
Comment on lines
+444
to
+445
| if overflow { | ||
| return nil, ErrGasUintOverflow |
There was a problem hiding this comment.
I see you've moved the error up the call stack. What's the motivation behind this change?
There was a problem hiding this comment.
IntrinsicGas is CalcIntrinsicGas + additional calculation. I think it makes sense for both of them to behave similarly and have the same return values.
|
@antonis19 It was missed out in a previous PR #13456. This solves a circular import on my AA branch. |
antonis19
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.