Commitment: do not use cell getter function to fold the row #13509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erigon-lib/commitment/commitment.go
Outdated
| // has to copy :( | ||
| if err = ctx.PutBranch(common.Copy(prefix), common.Copy(update), prev, prevStep); err != nil { | ||
| return 0, err | ||
| if fields&fieldStateHash != 0 { |
There was a problem hiding this comment.
can add method fields.Has(fieldStateHash)
AskAlexSharov
approved these changes
Jan 28, 2025
| if err != nil { | ||
| return fmt.Errorf("failed to encode leaf node update: %w", err) | ||
| } | ||
| if err = hph.ctx.PutBranch(common.Copy(updateKey), common.Copy(del), nil, 0); err != nil { |
There was a problem hiding this comment.
Inside ctx.PutBranch:
AddPrevValue- does copy insideDomainUpdate- does copy inside
in this case:ctx.PutBranchalso can do copy inside?
awskii
added a commit
that referenced
this pull request
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors how we collect trie branch updates.