Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement get proof rpc endpoint #13291

Merged
merged 6 commits into from
Jan 24, 2025
Merged

implement get proof rpc endpoint #13291

merged 6 commits into from
Jan 24, 2025

Conversation

shotasilagadze
Copy link
Contributor

@shotasilagadze shotasilagadze commented Dec 31, 2024 •
edited
Loading

@shotasilagadze shotasilagadze marked this pull request as draft December 31, 2024 18:44
@shotasilagadze shotasilagadze force-pushed the implement_eth_get_proof branch 4 times, most recently from a19d2f9 to 91ff2b0 Compare January 1, 2025 11:46
@shotasilagadze shotasilagadze marked this pull request as ready for review January 1, 2025 11:46
@shotasilagadze shotasilagadze force-pushed the implement_eth_get_proof branch 2 times, most recently from fee4a79 to c76029b Compare January 1, 2025 12:04
@shotasilagadze shotasilagadze linked an issue Jan 1, 2025 that may be closed by this pull request
Implement eth_getProof for "latest" Tag in Erigon 3 #13201
Closed
@shotasilagadze shotasilagadze force-pushed the implement_eth_get_proof branch from c76029b to c3f515d Compare January 1, 2025 12:23
@Giulio2002
Copy link
Contributor

Add unit tests + remove printlns. @awskii will give a more meaningful review tho. this is not my domain

@shotasilagadze shotasilagadze force-pushed the implement_eth_get_proof branch 2 times, most recently from 0433019 to 3b4808f Compare January 3, 2025 06:45
@shotasilagadze shotasilagadze force-pushed the implement_eth_get_proof branch 3 times, most recently from a2c6086 to 970d2c1 Compare January 6, 2025 07:26
awskii
awskii reviewed Jan 6, 2025
View reviewed changes
turbo/jsonrpc/eth_call.go Outdated Show resolved Hide resolved
awskii
awskii reviewed Jan 6, 2025
View reviewed changes
turbo/jsonrpc/eth_call.go Outdated Show resolved Hide resolved
awskii
awskii reviewed Jan 6, 2025
View reviewed changes
turbo/jsonrpc/eth_call.go Outdated Show resolved Hide resolved
@shotasilagadze shotasilagadze force-pushed the implement_eth_get_proof branch 3 times, most recently from 9337a4b to b3bc88c Compare January 7, 2025 09:13
antonis19
antonis19 reviewed Jan 7, 2025
View reviewed changes
erigon-lib/trie/proof.go Outdated Show resolved Hide resolved
antonis19
antonis19 reviewed Jan 7, 2025
View reviewed changes
turbo/jsonrpc/eth_call.go Outdated Show resolved Hide resolved
awskii
awskii requested changes Jan 9, 2025
View reviewed changes
turbo/jsonrpc/eth_call.go Outdated Show resolved Hide resolved
turbo/jsonrpc/eth_call.go Outdated Show resolved Hide resolved
@shotasilagadze shotasilagadze force-pushed the implement_eth_get_proof branch from 786cbc8 to ee64763 Compare January 10, 2025 09:50
@shotasilagadze shotasilagadze force-pushed the implement_eth_get_proof branch from ee64763 to 064242e Compare January 10, 2025 09:58
@shotasilagadze shotasilagadze requested a review from awskii January 11, 2025 12:12
@zzzckck zzzckck mentioned this pull request Jan 14, 2025
Closed
@shotasilagadze shotasilagadze force-pushed the implement_eth_get_proof branch from 06f3e13 to d044cdb Compare January 14, 2025 07:57
@shotasilagadze shotasilagadze force-pushed the implement_eth_get_proof branch 3 times, most recently from 8401c12 to b92bd33 Compare January 20, 2025 11:56
awskii
awskii reviewed Jan 21, 2025
View reviewed changes
turbo/jsonrpc/eth_call.go Outdated Show resolved Hide resolved
awskii
awskii reviewed Jan 21, 2025
View reviewed changes
turbo/jsonrpc/eth_call.go Outdated Show resolved Hide resolved
awskii
awskii reviewed Jan 21, 2025
View reviewed changes
turbo/jsonrpc/eth_call.go Outdated Show resolved Hide resolved
@shotasilagadze shotasilagadze force-pushed the implement_eth_get_proof branch 2 times, most recently from 35b0cf3 to cc2dbc7 Compare January 22, 2025 17:45
awskii
awskii reviewed Jan 23, 2025
View reviewed changes
turbo/jsonrpc/eth_call.go Outdated Show resolved Hide resolved
awskii
awskii reviewed Jan 23, 2025
View reviewed changes
turbo/jsonrpc/eth_call.go Outdated Show resolved Hide resolved
@shotasilagadze shotasilagadze force-pushed the implement_eth_get_proof branch from cc2dbc7 to 5fbe2b3 Compare January 23, 2025 16:20
@shotasilagadze shotasilagadze merged commit 654e24f into main Jan 24, 2025
13 checks passed
@shotasilagadze shotasilagadze deleted the implement_eth_get_proof branch January 24, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonis19 antonis19 antonis19 approved these changes

@awskii awskii awskii approved these changes

@Giulio2002 Giulio2002 Awaiting requested review from Giulio2002

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement eth_getProof for "latest" Tag in Erigon 3
5 participants
@shotasilagadze @Giulio2002 @awskii @antonis19 @shotasilagadzetaal