space retired metric added (#13454)

closes #13233 Co-authored-by: JkLondon <[email protected]>
erigontech · Jan 16, 2025 · acb5eee · acb5eee
1 parent 5fcefc6
commit acb5eee
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 0 deletions.
diff --git a/cmd/prometheus/dashboards/erigon_internals.json b/cmd/prometheus/dashboards/erigon_internals.json
@@ -5727,6 +5727,18 @@
               "legendFormat": "dirty: {{instance}}",
               "range": true,
               "refId": "B"
+            },
+            {
+              "datasource": {
+                "type": "prometheus",
+                "uid": "${DS_PROMETHEUS}"
+              },
+              "editorMode": "code",
+              "expr": "tx_retired{instance=~\"$instance\"}",
+              "interval": "",
+              "legendFormat": "limit: {{instance}}",
+              "range": true,
+              "refId": "C"
             }
           ],
           "title": "Tx Size",

diff --git a/dashboards/erigon_custom_metrics/erigon_custom_metrics.internal.json b/dashboards/erigon_custom_metrics/erigon_custom_metrics.internal.json
@@ -5543,6 +5543,18 @@
               "legendFormat": "dirty: {{instance}}",
               "range": true,
               "refId": "B"
+            },
+            {
+              "datasource": {
+                "type": "prometheus",
+                "uid": "${DS_PROMETHEUS}"
+              },
+              "editorMode": "code",
+              "expr": "tx_retired{instance=~\"$instance\"}",
+              "interval": "",
+              "legendFormat": "limit: {{instance}}",
+              "range": true,
+              "refId": "C"
             }
           ],
           "title": "Tx Size",

diff --git a/erigon-lib/kv/kv_interface.go b/erigon-lib/kv/kv_interface.go
@@ -85,6 +85,7 @@ var (
 	TxSpill   = metrics.GetOrCreateGauge(`tx_spill`)   //nolint
 	TxUnspill = metrics.GetOrCreateGauge(`tx_unspill`) //nolint
 	TxDirty   = metrics.GetOrCreateGauge(`tx_dirty`)   //nolint
+	TxRetired = metrics.GetOrCreateGauge(`tx_retired`) //nolint
 
 	DbCommitPreparation = metrics.GetOrCreateSummary(`db_commit_seconds{phase="preparation"}`) //nolint
 	//DbGCWallClock       = metrics.GetOrCreateSummary(`db_commit_seconds{phase="gc_wall_clock"}`) //nolint

diff --git a/erigon-lib/kv/mdbx/kv_mdbx.go b/erigon-lib/kv/mdbx/kv_mdbx.go
@@ -701,6 +701,7 @@ func (tx *MdbxTx) CollectMetrics() {
 	}
 
 	kv.TxDirty.SetUint64(txInfo.SpaceDirty)
+	kv.TxRetired.SetUint64(txInfo.SpaceRetired)
 	kv.TxLimit.SetUint64(tx.db.txSize)
 	kv.TxSpill.SetUint64(txInfo.Spill)
 	kv.TxUnspill.SetUint64(txInfo.Unspill)