refactor(simplebot)🔧: Refactor JSON response handling to use Pydantic models #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ericmjl
commented
Dec 20, 2024
ericmjl
commented
- Added import for Pydantic BaseModel.
- Implemented checks for pydantic_model attribute and its inheritance from BaseModel.
- Updated the JSON response format to use json_schema from the Pydantic model.
… models - Added import for Pydantic BaseModel. - Implemented checks for pydantic_model attribute and its inheritance from BaseModel. - Updated the JSON response format to use json_schema from the Pydantic model.
|
…andling - Filter message dumps to include only 'role' and 'content' keys. - Change response format assignment to use direct model attribute. - Remove unused imports and simplify task message generation. - Streamline message processing and validation in StructuredBot.
…st handling - Remove redundant model_config from StructuredBot class. - Correct data type in test_structuredbot for mock_response.content to use a dictionary instead of a string.
… response - Correct the format of mock_response.content to be a JSON string.
…irectly. - Updated the StructuredBot to use the parsed codeblock directly in model construction. - Modified the CommitMessage model to require the footer field explicitly.
…eration function. - Eliminated an unnecessary print statement used for debugging purposes. - Ensured the function returns the response without extraneous output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.