[pull] master from web-platform-tests:master #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* [WebDriver BiDi] Fix issue with cached JS * Update comments * Apply suggestions from code review Co-authored-by: Alex Rudenko <[email protected]> --------- Co-authored-by: Alex Rudenko <[email protected]>
Bug: 388456248 Change-Id: Ia01ea22c4c6684e6909fa3dc1041817924db5cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6157663 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Munira Tursunova <[email protected]> Cr-Commit-Position: refs/heads/main@{#1403522}
See WebKit/WebKit#38658 for context.
* Allow patially update to wpt manifest To run WPTs locally, developers usually only run a few of tests each time. Updating WPT manifest for the whole WPT Repo is not necessary and took ~3 seconds on a performant develop machine. And this can take forever if the developer is using a remote file system. This change allows updating WPT manifest for tests only intended to be run. This brings down the test time for a few tests to ~0.5 seconds. Additional work is needed to plug in this into the test runner.
Option elements in customizable select have place-items:center in order to vertically center the text of options. Since place-items is a shorthand for align-items and justify-items, we are unintentionally horizontally centering text in some cases. This patch replaces it with just align-items which effectively unsets the justify-items property. Change-Id: I540316dd4ff3512b5e48b7efac9f4794890693e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6153916 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Traian Captan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1403635}
See the bug for details, but it's possible (and ok) to already have a closewatcher in showModal(). I also found a test that wasn't being run, due to an error in a prior migration. Fixed: 384549097 Change-Id: I4f32e782a01cda79c63088b9bbf8ea41e158703e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6153855 Auto-Submit: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1403636}
Implements w3c/webappsec-permissions-policy#546 Bug: 40941424 Change-Id: I969a7ce326986b2a05f9417038f5d164ca6308dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5925839 Reviewed-by: Ian Clelland <[email protected]> Reviewed-by: Mustafa Emre Acer <[email protected]> Auto-Submit: Jun Kokatsu <[email protected]> Commit-Queue: Mustafa Emre Acer <[email protected]> Cr-Commit-Position: refs/heads/main@{#1403647}
Add coverage for reset_after=true and bidirection cases. Increase ULP to 6 for bidirectional. Bug: 360052663 Change-Id: Ic488a211625b8d74be7242412af631fb65cc0698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5991963 Reviewed-by: ningxin hu <[email protected]> Commit-Queue: Phillis Tang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1403673}
These tests were written before WPT supported fuzzy-matching, and these tests require fuzziness. This CL migrates them, updates them, and adds fuzziness where needed. Note that one test (backdrop-filter-browser-zoom.html) is left as a web_test because it uses `testRunner.setPageZoomFactor()`. Fixed: 41467763 Change-Id: I5480a0d87dc72fb707cc22ac034929d32f3b439f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6150610 Commit-Queue: Mason Freed <[email protected]> Auto-Submit: Mason Freed <[email protected]> Reviewed-by: Xianzhu Wang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1403806}
This reverts commit 480ab2f6779dfd0ceb88298f8a828b9d3f881d90. Reason for revert: No longer need these debug message. Original change's description: > bluetooth: Add log for debugging flaky issue 1430625 > > Add more logging for the test characteristic-is-removed.https.window.js > to identify which step of the process is causing the timeout on Mac CI > builder Mac10.14. > > Bug: 1430625 > Change-Id: I0b266857a3346021814357146ddc0bad2b87df5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4442286 > Reviewed-by: Matt Reynolds <[email protected]> > Commit-Queue: Jack Hsieh <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1132113} Bug: 1430625 Change-Id: I36d9639e4e7f1bbf37b625611239de9282393098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6159507 Commit-Queue: Jack Hsieh <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/main@{#1403887}
…itionAvailable This CL adds web platform tests for the installOnDeviceSpeechRecognition and onDeviceSpeechRecognitionAvailable methods of the Web Speech API. Change-Id: If3c9d54bca005dbbd8aa625df5821884761a446e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6150488 Commit-Queue: Evan Liu <[email protected]> Reviewed-by: Frank Liberato <[email protected]> Cr-Commit-Position: refs/heads/main@{#1403950}
… worklet" This is a reland of commit f0cab8e2346b2a62aa3be1d5a41ec7737bf335af The original CL incorrectly attempted to access args[0].As<v8::Object>() even when the initial IDL validation (args_converter.is_success() && !args[0]->IsObject()) failed. This could lead to unpredictable behavior as args[0] might not be a valid object. This reland fixes this by ensuring that args[0].As<v8::Object>() is only accessed when args_converter.is_success() is true. Code changes: see the diff between Patchset 1 and Patchset 2 Original change's description: > [shared storage] Implement sharedStorage.batchUpdate() for PA worklet > > Add sharedStorage.batchUpdate() function. Parse arguments into > the 'methods' sequence and a 'with_lock' optional flag, and > propagate the result to the browser process to invoke the > `SharedStorageLockManager::SharedStorageBatchUpdate()` API. > > This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web > Lock integration proposal: > - WICG/shared-storage#199 > - WICG/shared-storage#205 > > Fuchsia-Binary-Size: Size increase is unavoidable. > Bug: 373899210 > Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850 > Commit-Queue: Yao Xiao <[email protected]> > Reviewed-by: Maks Orlovich <[email protected]> > Reviewed-by: Cammie Smith Barnes <[email protected]> > Reviewed-by: Giovanni Ortuno Urquidi <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1401673} Bug: 373899210 Change-Id: I1782e6af1de95cc643053aa80c2a15f601da56a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6132126 Reviewed-by: Maks Orlovich <[email protected]> Reviewed-by: Giovanni Ortuno Urquidi <[email protected]> Commit-Queue: Yao Xiao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1403952}
…duced through nesting. Differential Revision: https://phabricator.services.mozilla.com/D233532 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1940212 gecko-commit: 44f971223b3786a3f9fac7043d1274f4e65b4990 gecko-reviewers: firefox-style-system-reviewers, emilio
…nline-size-003.html. As noted in the bug report, I recently added these tests, but they turned out to fail in Chrome because they were inadvertently depending on a Firefox bug (specifically https://bugzilla.mozilla.org/show_bug.cgi?id=1940321 ). This patch removes that inadvertent dependency, which makes them pass in Chrome. This change does introduce some new test failures in Firefox, which appear to be cases where we're over-counting the border/padding on the abspos element; I'll investigate and address those failures in a followup, but for now I'm aiming to make the test's expectations correct. Differential Revision: https://phabricator.services.mozilla.com/D233471 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1940367 gecko-commit: fa002a402ee102a8f3985a758fec7509f8667ec4 gecko-reviewers: layout-reviewers, emilio
Add test coverage for w3c/webrtc-pc#3023 which unblocks merging the PR (it has "editors can integrate"). Specifically it should be possible to negotiate H265 even if the level-id is downgraded in the SDP answer (not throwing on level-id mismatch). - H265 is behind flags so a virtual test suite is added. - If bot lacks HW capabilities to do H265, the tests will PRECONDITION_FAILED. To avoid reverting tests we will allow the bots to both pass and fail, I filed crbug.com/388299759. Some of the tests FAIL even when they run: passing these tests will be covered by crbug.com/381407888. Bug: chromium:381407888, webrtc:41480904, chromium:388299759 Change-Id: Ie017560b4310418a4c9ed854dcb09136b9b446e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6148192 Reviewed-by: David Baron <[email protected]> Commit-Queue: Henrik Boström <[email protected]> Reviewed-by: Evan Shrubsole <[email protected]> Cr-Commit-Position: refs/heads/main@{#1404052}
Bug: 387828384 Change-Id: Id15097130d36dcff6aa30819c7f8f480ddde5c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6148669 Auto-Submit: Keith Cirkel <[email protected]> Reviewed-by: Luke <[email protected]> Commit-Queue: Keith Cirkel <[email protected]> Cr-Commit-Position: refs/heads/main@{#1404116}
https://drafts.csswg.org/css2/#collapsing-borders > in this model, a table does not have padding https://drafts.csswg.org/css-tables/#collapsed-style-overrides > The padding of the table-root is ignored (as if it was set to 0px). Signed-off-by: Oriol Brufau <[email protected]>
* Add more TrustedType tests for eval and function constructor. We already have many tests for eval and function constructor but things are a bit messy and it's difficult to figure out what we are covering. Write a simple test to test blocking, compilationSink and execution in workers. * also test indirect eval and more function constructor
The test is changed in 3 ways: - All browsers are failing the 4th promise_test here [1] because the test was wrongly making a pointer-capture request for the `<iframe>` element on the top frame instead of an element inside the iframe. This is fixed. - Removed the id `innerFrameElement` from all promise_tests to avoid possible confusion along the same line. - When the pointer-capture request is expected to fail, dragging the pointer into or out-of an iframe activates a iframe-capture behavior, probably on most browsers, that is not defined in the PointerEvent spec. Removed pointer dragging in these cases to keep the tests focused on well-defined behaviors. [1] https://wpt.fyi/results/pointerevents/pointerevent_pointercapture_in_frame.html%3Fmouse?label=experimental&label=master&aligned Bug: 357041460 Change-Id: Ibda5890f5d7d2feb90868aa8e4e99a30ae51a180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6150548 Commit-Queue: Mustaq Ahmed <[email protected]> Reviewed-by: Robert Flack <[email protected]> Auto-Submit: Mustaq Ahmed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1404203}
* Add TrustedType tests for iframe.srcdoc. It seems we already have some tests for iframe.srcdoc but things are a bit messy so it's unclear whether we cover blocking, conversion check and sink names (#494) and null string edge case. Add a simple test doing that, similar to other `block-string-assignment-to-*` tests. * fix many errors
Co-authored-by: wpt-pr-bot <[email protected]>
…pts() (#49999) It's "Worker importScripts" by 1.2.1 of https://html.spec.whatwg.org/multipage/workers.html#importing-scripts-and-libraries
Currently it uses `doc.body` but when `doc == document`, this is causing errors in `testharness.js`: `TypeError: can't access property "addEventListener", output_document.getElementById(...) is null`
Per the history[1], the fix in crrev.com/c/6149989 does not appear to have succeeded. This patch makes another attempt borrowing logic from waitForCompositorReady which has stronger implications about the readiness of the compositor thread than waitForCompostiorCommit which crrev.com/c/6149989 was based on. [1] https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2F%3Aheadless_shell_wpt%2Fexternal%2Fwpt%2Ftouch-events%2Fsingle-touch.html?q=V%3Abuilder%3DLinux%2520Tests+V%3Aos%3DUbuntu-22.04+V%3Atest_suite%3Dheadless_shell_wpt_tests [email protected] Bug: 385526611 Change-Id: I52bbd8023fe50c7076890efedf7caddbdfaa330c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164303 Commit-Queue: David Awogbemila <[email protected]> Reviewed-by: Mustaq Ahmed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1404305}
The type for willReadFrequently is boolean, not an enum with values of "true", "false", and "undefined". Add WPT tests for this. And for the rest of the attributes. The WPT tests failed for the desynchronized property because, when it was discovered that this feature was never implemented on macOS, it was disabled at compile time, when parsing the input from V8, losing the information required to correctly implement getContextAttributes. Add a temporary workaround for this situation by separately storing the specified desynchronized value. Bug: 388290815 Change-Id: I00e6b6c82a23cdb627a3eba1314ebf3b0f9abf9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6157723 Reviewed-by: Yi Xu <[email protected]> Commit-Queue: ccameron chromium <[email protected]> Reviewed-by: Aaron Krajeski <[email protected]> Cr-Commit-Position: refs/heads/main@{#1404356}
…if it's visible by a following <br> but it's removed This is a hack until bug 503838 is fixed. The other browsers puts an NBSP for the last ASCII white-space immediately before a block boundary to make it visible. However, we currently need to keep using an ASCII white-space as-is with putting a padding `<br>` element. However, web apps may delete the `<br>` for some reasons without maintaining the preceding collapsible white-space visibility since it's not required in the other browsers. Therefore, this patch replaces the white-spaces only when we meet such situation. Of course, this breaks the undo stack, but touching the DOM anyway causes breaking the undo stack. Thus, we can trust the web app as that it manages their on undo stack. Differential Revision: https://phabricator.services.mozilla.com/D233472 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1940278 gecko-commit: 020e3aecfaaa47b5ed8497bcc9572d70a9b5e549 gecko-reviewers: m_kato
This simplifies the offscreen and worker tests a lot, but it also allows them to be implemented with the same structure as all other tests, with three distinct sections: - Draw background. - Draw foreground. - Assert This will help in the follow-up CLs, where these tests will be migrated to the new test generator. Having the same structure will allow all of these tests to have a shared base implementation. The changes in gentestutils.py are pretty hacky, but it's hard to do anything better given the state of this file. Since this script will be deleted soon, there's no point in spending time to implement this in a better way. Bug: 40207206 Change-Id: I85eab5c12f328bda699d92ab8aecb804100e9d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6192518 Reviewed-by: Andres Ricardo Perez <[email protected]> Commit-Queue: Jean-Philippe Gravel <[email protected]> Cr-Commit-Position: refs/heads/main@{#1410563}
This CL updates the W3C test expectations so that onevent handlers are now compared to both objects and functions. This is because onevent handlers, when unset, is null, so should be of type object, and when set, it is of type function. When using EME Logger, the extension sets it, which causes failures. Bug: 348059278 Change-Id: I15d980d4a54b98346c89ba06b8d8172ca9e89b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020800 Auto-Submit: Vikram Pasupathy <[email protected]> Commit-Queue: Vikram Pasupathy <[email protected]> Reviewed-by: John Rummell <[email protected]> Cr-Commit-Position: refs/heads/main@{#1410582}
In preparation for actually sending up mojo_from_floor data, this renames `mojo_from_floor` in VRStageParameters to `mojo_from_stage` to reflect what it actually is. Bug: 390216623 Change-Id: I3428517b34e614c1c35e206bfafe98893f042fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6183158 Commit-Queue: Alexander Cooper <[email protected]> Reviewed-by: Elly FJ <[email protected]> Reviewed-by: Fred Shih <[email protected]> Reviewed-by: Piotr Bialecki <[email protected]> Cr-Commit-Position: refs/heads/main@{#1410694}
This CL adds a DocumentIsolationPolicy reporter for SharedWorkers, based on their DocumentIsolationPolicy. It is stored in the SharedWorkerHost, and communicates with a ReportingObserver bound in the WorkerContext. This CL also fixes an issue where the COEP reporter of the SharedWorker was not connected to a ReportingObserver. This CL is part of a chain of CLs implementing DocumentIsolationPolicy 1) Add DocumentIsolationPolicyReporter 2) Implement DocumentIsolationPolicyReporter 3) Pass the reporter to URLloaderFactory 4) Plumb DIP reporter into ServiceWorkers 5) Add a DIP reporter to DedicatedWorker 6) Add a DIP reporter to SharedWorker <- you are here 7) Plumb DIP reporter in CacheStorage reporting: Bug: 333029815, 40190911 Change-Id: Ifb5c3883376bd5a255dd307ff1cb8f0c1b90f964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6187126 Reviewed-by: Mike West <[email protected]> Reviewed-by: Hiroki Nakagawa <[email protected]> Commit-Queue: Camille Lamy <[email protected]> Cr-Commit-Position: refs/heads/main@{#1410793}
…and "session.unsubscribe". Differential Revision: https://phabricator.services.mozilla.com/D234534 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1938576 gecko-commit: 721a097d8357b02c40c58598223caaba129bb004 gecko-reviewers: webdriver-reviewers, jdescottes
Copy the anchor evaluator and try fallback rules from the StyleRecalcContext passed for the original ResolveStyle. Bug: 40337057 Change-Id: Iddb90644b688db8372fe59680a7ac1c6df0eef7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6194415 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Rune Lillesveen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1410840}
Bug: 370065759 Change-Id: I3acb9197ca131752d1f2aef2e9830542716fa411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198289 Commit-Queue: Rune Lillesveen <[email protected]> Reviewed-by: Daniil Sakhapov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1410854}
This reverts commit 18cd9effcba79aea3d11169444c27279aec43b84. Reason for revert: https://crbug.com/391393420 Original change's description: > Display resize observer loop notifications in devtools > > Resize observer loop notifications errors that are not canceled should > appear in the devtools console so authors have some indication of the > error. This patch does this with two changes: > 1) A valid script state is used so the exception is not dropped in > MainThreadDebugger::ExceptionThrown. > 2) A ScriptValue of the error message is used so a message appears in > the console. Without a ScriptValue, MainThreadDebugger::ExceptionThrown > will print "Uncaught null". > > The console behavior is not specified so two tentative tests have been > added (Safari passes these). A TODO has been added to provide a useful > source location, as suggested by https://crbug.com/40667137#comment10. > > Fixed: 40667137 > Change-Id: Id20c977efd1fc03caba517ecec3bf3b0a9f53163 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5970814 > Auto-Submit: Philip Rogers <[email protected]> > Reviewed-by: Andrey Kosyakov <[email protected]> > Commit-Queue: Stefan Zager <[email protected]> > Reviewed-by: Stefan Zager <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1375538} Bug: 391393420 Change-Id: I2234757d39320a6d120f7605f7fc3fe78344123d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6197801 Auto-Submit: Philip Rogers <[email protected]> Commit-Queue: Philip Rogers <[email protected]> Reviewed-by: Fredrik Söderquist <[email protected]> Commit-Queue: Fredrik Söderquist <[email protected]> Cr-Commit-Position: refs/heads/main@{#1410882}
See the discussion here: openui/open-ui#1138 The TL;DR is that input-based buttons are legacy and not to be "encouraged". Bug: 326681249 Change-Id: I9100c66eceb21a06e176da02de52304a81a8288b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6196537 Commit-Queue: David Baron <[email protected]> Auto-Submit: Mason Freed <[email protected]> Reviewed-by: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1410898}
There was previously an `interest-invokers.tentative.idl` but no test file to run it. This adds the idlharness.html tester, and updates the .idl file to match the current implementation. Bug: 326681249 Change-Id: I467b389b00f969fa78fa51d47df5c9f2ef23dfd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6197038 Reviewed-by: David Baron <[email protected]> Commit-Queue: David Baron <[email protected]> Auto-Submit: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1410899}
This test was failing on all browsers because before the paragraph "Test passes if there is a filled green square and *no red*" was getting styled with some unnecessary CSS which is not present in the reference. Removing this CSS which is irrelevant to the actual table being tested fixes the problem. Signed-off-by: Oriol Brufau <[email protected]>
(As part of V1 trusted scoring signals fetch). See WICG/turtledove#792 (comment) for more context. Bug: 383513677 Change-Id: I27e2a3357c3897edd1d1c612186a39a0afa91cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6149249 Commit-Queue: Maks Orlovich <[email protected]> Reviewed-by: mmenke <[email protected]> Reviewed-by: Giovanni Ortuno Urquidi <[email protected]> Cr-Commit-Position: refs/heads/main@{#1410923}
This CL takes a first pass at implementing one spelling of the proposal in https://mikewest.github.io/inline-integrity/. It only addresses `<script>` elements; if we decide that it's a reasonable direction, adding support for `<style>` should be pretty straightforward. If we decide it's not a reasonable direction, this is easy to rip out. :) Bug: 391907163 Change-Id: I35887e1c6d017ffbf3ea99f11bbd12f131c785e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6192623 Reviewed-by: Antonio Sartori <[email protected]> Reviewed-by: Fredrik Söderquist <[email protected]> Commit-Queue: Mike West <[email protected]> Cr-Commit-Position: refs/heads/main@{#1410927}
Some of these tests were using `no_red_3x3_monospace_table-ref.xht` as a reference. However, the reference has a single 3x3 table, while the tests put each row on a different table. Thus text wasn't aligning well, and the tests were failing on all browsers. Therefore this adds a new reference for these tests. Some other tests were instead adding a background on their columns. These also get their own reference. But additionally, these tests attempt to work as visual tests by overlapping two tables: one with green text in front of another with red text. However, this feature was broken since both tables had a background, so the underlying one was not visible at all. Therefore, I'm also removing the background of the table at the front. Note that these tests come in pairs that just switch which one is in front, so no functionality is lost. Signed-off-by: Oriol Brufau <[email protected]>
This patch implements a fix while we wait for a resolution here: w3c/csswg-drafts#11185 Bug: 389830175 Change-Id: Ie0fd5d655cc5ac83f68fb0da0cfd2c7e5de49214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6019064 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1410952}
The old link seemed like copypasta. No functional change. Change-Id: Iea808b5b4e5e35ceccc362657f1edf53d5153172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6196708 Auto-Submit: Mason Freed <[email protected]> Reviewed-by: Dominic Farolino <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1410975}
Having the same assertions in all tests will simplify things when we migrate these tests to the new test generator, allowing all tests to share the same common base implementation. Bug: 40207206 Change-Id: Ifaa73c2b8021ef00290d36729d3f54094951d9d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6192519 Commit-Queue: Jean-Philippe Gravel <[email protected]> Reviewed-by: Andres Ricardo Perez <[email protected]> Cr-Commit-Position: refs/heads/main@{#1410976}
The output size is calculated by upstream caller based on the roundingType, but CoreML needs to know the roundingType and it needs to match with the output size. When cache directory is not allowed access, a mismatch just silently fail, but when CoreML has cache access it crashes on a size mismatch. So reconstruct the roundingType from the output size. Added one test case because currently all paddings are asymmetric but coreml only support symmetric paddings for ceil mode. Change-Id: Ic1771ccfae07d43bac36fb617ca2b9b9cb364ec2 Bug: 334914466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6182746 Reviewed-by: Reilly Grant <[email protected]> Commit-Queue: Phillis Tang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1411014}
This change fixes a bug where a transition on a root element would cause a crash if GetKeyframes() was called via javascript. The crash was caused by the parent style not being available in the style resolver state. This change adds a new function that initializes the parent style as the initial style, as was done to fix crbug.com/40703845 Bug: 387447929 Change-Id: Iaaef09b4cf003751082d1c818e55f4b9f792ab5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6142431 Reviewed-by: Kevin Ellis <[email protected]> Commit-Queue: Claire Chambers <[email protected]> Cr-Commit-Position: refs/heads/main@{#1411049}
Co-authored-by: wpt-pr-bot <[email protected]>
dialog:modal and [inert] should set 'interactivity' to 'auto' and 'inert' respectively according to the spec. Bug: 370065759 Change-Id: Id270eeb7f6672cdb43e6c69f2367a2aa5a68b79e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6197981 Reviewed-by: Robert Flack <[email protected]> Commit-Queue: Rune Lillesveen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1411062}
When a live range attached to a document is modified, this change is upstreamed to the FrameSelection. New spec [1] says to only update the composed live range (frame selection)'s start position if setStart is called and only update end position if setEnd is called: whatwg/dom#1342 This is the proposal (B) discussed here: whatwg/dom#772 (comment) To do this, we define enum UpdateSelectionIfAddedToSelection to have three possible update selection behavior: 1. kAll, set selection to have the same start and end as range. --> Default case, when both setStart, setEnd are called. 2. kStartOnly, set selection to have the same start as range only. --> When only setStart is called. 3. kEndOnly, set selection to have the same end as range only. --> When only setEnd is called. We add a WPT test for this new behavior, which only affects the output of getComposedRanges() as it is the only API that accesses the frame selection's endpoints directly. Change-Id: I51ea53fe6156164ba3fbe38b14bc47ff502633b1 Bug: 40286116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6188157 Reviewed-by: Siye Liu <[email protected]> Commit-Queue: Di Zhang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1411209}
This CL ensures that after `Observable.from()` is called with an iterable, if the resulting Observable fails to iterate when subscribed to, all errors are plumbed to the subscriber. This matches the spec PR in WICG/observable#160. R=masonf Bug: 363015168 Change-Id: I31a38d7f57ec7ab5b29388d908a6a58e0b3c1905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6199726 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1411273}
Differential Revision: https://phabricator.services.mozilla.com/D235147 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1942820 gecko-commit: 76ecd4fd31b3e0a9426a3436d24ff8c190a7624e gecko-reviewers: necko-reviewers, kershaw
The test currently fails because the inert attribute still makes elements html inert. Bug: 370065759 Change-Id: Id80e276e31294ce00d1db8a854927ea7441ad087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198342 Commit-Queue: Rune Lillesveen <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1411319}
Bug: 391907163 Change-Id: I55e67d9256ccbc05b2ffc432bd9dc258762af919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198224 Reviewed-by: Fredrik Söderquist <[email protected]> Commit-Queue: Mike West <[email protected]> Cr-Commit-Position: refs/heads/main@{#1411395}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )