Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

triage: fix cmd. and omit 0-count items by default #65

Merged
merged 11 commits into from
Dec 27, 2023
Merged

triage: fix cmd. and omit 0-count items by default #65

merged 11 commits into from
Dec 27, 2023

Conversation

ErichDonGubler
Copy link
Collaborator

@ErichDonGubler ErichDonGubler commented Nov 13, 2023 •
edited
Loading

@ErichDonGubler ErichDonGubler added enhancement New feature or request A-webgpu-cts labels Nov 13, 2023
Base automatically changed from triage-by-intermittency to main November 13, 2023 22:20
@ErichDonGubler ErichDonGubler force-pushed the triage-passing-total-counts branch 2 times, most recently from 162b944 to 536cb83 Compare November 20, 2023 18:10
@ErichDonGubler ErichDonGubler force-pushed the triage-passing-total-counts branch from 536cb83 to ad9df7f Compare December 8, 2023 17:18
@ErichDonGubler ErichDonGubler force-pushed the triage-passing-total-counts branch 2 times, most recently from f6720c2 to f51908b Compare December 27, 2023 20:19
@ErichDonGubler ErichDonGubler changed the title Refine triage yet again triage: fix and omit 0-count items by default Dec 27, 2023
@ErichDonGubler ErichDonGubler force-pushed the triage-passing-total-counts branch from f51908b to 98671b6 Compare December 27, 2023 20:23
@ErichDonGubler ErichDonGubler self-assigned this Dec 27, 2023
@ErichDonGubler ErichDonGubler changed the title triage: fix and omit 0-count items by default triage: fix cmd. and omit 0-count items by default Dec 27, 2023
@ErichDonGubler
refactor: document read_gecko_files_at's return value
91b5509
@ErichDonGubler
build: use workspace version of thiserror
5f85190
@ErichDonGubler
refactor: remove unused impl Display for TestPath
be42d8b
@ErichDonGubler
refactor: split concat!-enated fmt. pattern intermittent tests > 0 …
f960b7f 
…check
@ErichDonGubler
refactor: split freak_out_do_nothing fmt. patterns into concat!-e…
c0a02b0 
…nated lines
@ErichDonGubler
refactor(triage): remove unnecessary SectionHeader wrapping
e850535
@ErichDonGubler
refactor: extract meta segment to sites of usage in TestPath inte…
be9a259 
…rnals
@ErichDonGubler
fix(triage)!: use TestPath::runner_url_path for test key
15718ff 
This fixes a breakage introduced by [#58], which broke the assumption
that we only analyzied `chunked`-style WPT metadata (oops, Spiderman
meme!). We trade out using the internal CTS test path we now fail to
extract for

[#58]: #58
@ErichDonGubler
refactor(triage): bring summary item display logic closer to extraction
4c96e4d
@ErichDonGubler
refactor: move intermittent disabled/SKIP check closer to extraction
27c67f4
@ErichDonGubler
feat(triage)!: elide 0 items with new default `--on-zero-count-item=h…
601432a 
…ide`
@ErichDonGubler ErichDonGubler force-pushed the triage-passing-total-counts branch from 98671b6 to 601432a Compare December 27, 2023 20:40
@ErichDonGubler ErichDonGubler marked this pull request as ready for review December 27, 2023 20:40
@ErichDonGubler ErichDonGubler merged commit cc7938e into main Dec 27, 2023
18 checks passed
@ErichDonGubler ErichDonGubler deleted the triage-passing-total-counts branch December 27, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ErichDonGubler ErichDonGubler

Labels
A-webgpu-cts enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't show triage PRIORITY items when their count is 0 (by default)
1 participant
@ErichDonGubler