Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Pydantic to v2.5.2 (latest) #19

Merged
merged 8 commits into from
Nov 28, 2023
Merged

Conversation

andrey-lepekhin
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (861c165) 100.00% compared to head (3de8fc6) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           40        42    +2     
=========================================
+ Hits            40        42    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrey-lepekhin
Copy link
Collaborator Author

andrey-lepekhin commented Nov 28, 2023

There are warnings from Pydantic triggered by val.model_dump() in pydjantic.py. They are shown on Django server start, during settings creation.

The warnings look like this:

UserWarning: Pydantic serializer warnings:
    Expected `str` but got `dict` - serialized value may not be as expected

As far as I understand this is the same issue here and it's being investigated.

Despite Pydantic static that is the default value, without this the demo django app will not start with error linking to https://errors.pydantic.dev/2.5/v/extra_forbidden
@andrey-lepekhin andrey-lepekhin merged commit e7c4565 into master Nov 28, 2023
5 checks passed
@andrey-lepekhin andrey-lepekhin deleted the bump_pydantic_to_v2 branch November 28, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants