Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-0042 Multi-Signature Wallet #88

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,5 @@ Please check out existing EIPs, such as [EIP-1](eip-0001.md), to understand the
| [EIP-0025](eip-0025.md) | Payment Request URI |
| [EIP-0027](eip-0027.md) | Emission Retargeting Soft-Fork |
| [EIP-0031](eip-0031.md) | Babel Fees |
| [EIP-0039](eip-0039.md) | Monotonic box creation height rule |
| [EIP-0039](eip-0039.md) | Monotonic box creation height rule |
| [EIP-0042](eip-0042.md) | Multi-Signature Wallet |
174 changes: 174 additions & 0 deletions eip-0042.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,174 @@
# EIP-41: Multi-Signature Wallet

- Author: lazypinkpatrick, vorujack, mhs_sam
- Status: Completed
- Created: 21-Jan-2023
- License: MIT
- Forking: not needed

This EIP defines a standard for multi-signature wallets based on EIP-11, which defines the multi-signature signing process.

## Introduction

On top of EIP-11, this EIP implements the following additional operations:

* Wallet creation and address derivation.
* Transaction signing based on EIP-11.

## Wallet Creation and Address Derivation

These parameters define an `N-out-of-M` multi-signature wallet:
aslesarenko marked this conversation as resolved.
Show resolved Hide resolved

* `M`: number of public keys.
* `N`: minimum signature required.

Each signer stores the set of extended public keys of all signers and a local copy of their secret.

An address is derived for each signer using their extended public key over a specified derivation path. The list of derived addresses for all signers is then used to compile a multi-sig contract that looks like this:

```
atLeast(
N,
Coll(
PK(Address1),
PK(Address2),
.
.
.
PK(AddressM)
)
)
```

Please note, this contract results in different addresses when the order of signers differs.

We must guarantee that all signers will have a unique and reproducible multi-signature wallet address. To do so, we use the same derivation path and sort the byte array of public keys in ascending order.

Then we will manually create the ErgoTree; since using the compiler could cause the resulting address to vary.

The address derivation algorithm is as follows:

Sort the list of signers' public keys before being used in the contract.
Create the required ergoTree array as follows:

- The first byte in the array is `10`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first byte is the header, which contains ErgoTree version bits.
While it is ok to always use one specific version, in the EIP it is better to have version as parameter.
And, if the version > 0, then size bit 3 should be set, and the size of tree bytes should be stored in as necessary (see section 5.5 in the spec)

- The number of constant values in the contract is encoded as a variable-length quantity (VLQ).
This number equals `M+1` (Constant `N` and `M` public keys)
- A byte with value `04` denotes the integer type,followed by the value of `N` encoded as VLQ.
- For each public key 35 bytes are used: 2 bytes with value `08cd`, followed by 33 bytes representing the public key.
- A byte with the value `98` indicates **"atLeast"**.
- Two bytes, with values `73` and `00`, respectively.
The value `00` indicates the VLQ-encoded index of value `N` in the list of constants.
- A constant byte with value `83`, the VLQ-encoded value of `M`, and a constant byte with value `08`
- For each public key (`M` times), a byte with value `73`,followed by the VLQ-encoded value of the index of the public key in the list of constants
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to use ErgoTree spec and specify here the ErgoTree using operation names from the specification.
And and most magic bytes in the text above are actually opcodes, so it is better to mention them (like "atLeast")


Therefore, for each derivation path, all wallets are able to generate a unique and similar byte array as an ErgoTree.

![Ergo Tree Bytes](./eip-0042/bytes.png)
aslesarenko marked this conversation as resolved.
Show resolved Hide resolved

## Transaction Signing

An unsigned transaction is generated on one wallet. This transaction may have been generated through ErgoPay or the dApp connector, or it could be an outgoing transaction to another address through the wallet itself.

After an unsigned transaction is generated, the wallet

Generates a commitment.
Stores its private part locally.
Shares a commitment as below

```
{
tx:<reduced transaction bytes encoded as base64>,
boxes:[encoded boxes as base64],
aslesarenko marked this conversation as resolved.
Show resolved Hide resolved
commitment: commitments encoded
}
```

The input `boxes:` are only used to display transactions on wallets.

The general commitment format is as follows. However, this general-purpose commitment can be used for any contract.
```
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Differs from EIP-11, see below

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, if EIP-11 is not suitable "as-is", then please explain why and if motivated, then EIP-11 should be updated. Then this EIP should follow EIP-11.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this format is used in the node, sigma-rust and other libs, see /wallet/generateCommitments.
I'm not sure why EIP-11 is not following this format.

"hint": "cmtReal",
"position": "0-0",
"type": "dlog",
"pubkey": {
"op": "205",
"h": "03a73c66970f14fc6450c6ab1a167cb4ba3baa64b20f731e22ec6840c70d27ef1c",
}
"a": "0253db866791af521ba4ab009509b6db89d272d9461636ee65eaa3e316884b21a4"
}
```

In a multi-signature wallet, a simplified version of commitment is used.

```
commitments: [
[<base64 string of commitment for public key index 0 in input 0>, ...]
[<base64 string of commitment for public key index 0 in input 1>, ...]
aslesarenko marked this conversation as resolved.
Show resolved Hide resolved
]
```

In the multi-signature wallet, a commitment is represented as a list of base64 strings to reduce the commitment size. Also, an empty string is used wherever a commitment is unavailable.

[//]: # (and we can transform these commitments to standard format:)
This reduced format can be transformed into the standard format:

```
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This format differs from the actual format in EIP-11 (index/position, pubkey/pk, a/commitment). Is EIP-11 outdated?

"hint": "cmtReal",
"position": "0-<commitment_index>",
"type": "dlog",
"pubkey": {
"op": "205",
"h": "<public key used in address generation at index commitment_index>"
},
"a": "<base16 encoded of commitment at index commitment_index>"
}
```

[//]: # (Because wallets want to pass this code via QRCode, each wallet can split it into chunks)

To transfer these commitments using QRCode, we can split the data into several chunks:

```
{
MSR: "{\"tx\": ...}",
n: <number of chunks>
p: <page number>
}
```

This data is transferred between multi-signature wallets until one wallet has at least `N` commitments (including its own).

This wallet creates a partially signed transaction with this encoding:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the last wallet create a "partially signed transaction" and not a fully signed transaction if it already has N commitments? Or does this sentence apply until N-1 commitments are collected?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see https://github.com/ergoplatform/eips/blob/9906f403f61d8592ab955494cc4310563f4067c6/eip-0011.md#signing-procedure.
It's a two-round protocol in which the parties generate commitments in the first round. The last party is able to partially sign (he has only one of the keys so he cannot fully sign) and then, each of them signs the transaction partially and sends the generated signature to another party. This process continues until the signature is completed.


```
{
partialTx: "<partially signed transaction encoded as base64>",
commitments: <ancoded commitments>
signed: [<base64 encoded of signed public keys>],
aslesarenko marked this conversation as resolved.
Show resolved Hide resolved
simulated: [<base64 encoded of simulated public keys>],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What means simulated? This is only the list of missing keys, which can be determined by the wallet address. Why do we need it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see https://storage.googleapis.com/ergo-cms-media/docs/ErgoScript.pdf, Appendix A2. Proving.
Those signers that do not participate in signing will be simulated. See above for details.

}
```

It can also be transferred using QRCode in several chunks:

```
{
MTX: "{\"partialTx\": ... }",
n: <number of chunks>
p: <page number>
}
```

The first signer creates a list of simulated signers, and other signers use this list.

Each signer:
Signs the partially signed transaction (if they still need to).
Adds their public key to the list.
Shares the data with the next signer.

The transaction will be broadcasted whenever the signer determines that the transaction has enough signatures.


Binary file added eip-0042/bytes.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a mistake.
The "Collection Element Data Type (SigmaProp)" is not saved.
Please check ConcreteCollectionSerializer and ValueSerializer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I got it, please elaborate.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On your picture, the "Collection Element Data Type (SigmaProp)" shown under "Repeated for each public key". This is not correct. That 08 value is stored only once. And you already showing it as "Collection Data Type (SigmaProp)"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to the doc, it seems you're right since Expression Serializations requires opCode and body; however, in the tests I'm getting parsing error if I eliminate those types and surprisingly it's working when type is added.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.