Add resource_dir override #90
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you vendor clang-tidy in a hermetic toolchain, it likely cannot find the builtin headers path. To solve this you have to pass `-resource-dir` to the correct path. This is similar to the new gcc option but with a different flag.
keith
commented
May 1, 2025
| @@ -40,6 +40,11 @@ def _clang_tidy_rule_impl(ctx): | |||
| rule_conlyopts = _get_copts_attr(ctx, "conlyopts") | |||
| rule_cxxopts = _get_copts_attr(ctx, "cxxopts") | |||
|
|
|||
| files = ctx.attr.clang_tidy_resource_dir.files.to_list() | |||
| if files: | |||
| directory = files[0].path.split("/include/")[0] | |||
There was a problem hiding this comment.
this is ugly but i think we'd have to use skylib directly to access a better api from the provider to improve this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you vendor clang-tidy in a hermetic toolchain, it likely cannot find
the builtin headers path. To solve this you have to pass
-resource-dirto the correct path. This is similar to the new gcc option but with a
different flag.