-
Notifications
You must be signed in to change notification settings - Fork 63
Add target to apply clang-tidy fixes #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oliverlee
wants to merge
1
commit into
erenon:master
Choose a base branch
from
oliverlee:apply-fixes-rule
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I run the example with:
this silently succeeds. If instead I run
I get the expected lint warning. I get tidy fixes applied with
or
|
4b1497a
to
1cd923b
Compare
any update? |
Hi, tried to use the fix patch, however, it seems to be confused by sandbox. I tried to add back
|
Are there any plans to continue this work? |
I haven't been working on these things recently so I'm very unlikely to. It
may be better to close this issue.
…On Fri, Mar 7, 2025, 05:22 Arvid Norlander ***@***.***> wrote:
Are there any plans to continue this work?
—
Reply to this email directly, view it on GitHub
<#39 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWT4J4LHPOZZ2IRNKCIKLL2TGMQNAVCNFSM6AAAAABYRGVFIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBWGQ2DIMRRHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: arvid-norlander]*arvid-norlander* left a comment
(erenon/bazel_clang_tidy#39)
<#39 (comment)>
Are there any plans to continue this work?
—
Reply to this email directly, view it on GitHub
<#39 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWT4J4LHPOZZ2IRNKCIKLL2TGMQNAVCNFSM6AAAAABYRGVFIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBWGQ2DIMRRHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.