Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature_brcoeff: slope-dependant breaking coefficient #12

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mpezerat
Copy link

@mpezerat mpezerat commented Oct 25, 2024

Pull Request Summary

Computes a slope-dependant breaking coefficient for the depth-induced breaking source term

Description

Computes a slope-dependant breaking coefficient (BRCOEF) for the depth-induced breaking source term. A new flag (BRFLAG) is added to SDB1 namelist to choose between a constant breaking coefficient (BRFLAG=F, default value) prescribed with BJALFA parameter (same as before) or the adapting breaking coeff. (BRFLAG=T). In such case, the slope coefficient can be slightly adapted by the user through BJALFA parameter (default value 40).
Several studies demonstrate the robustness of this parameterization already implemented in the spectral wave model WWM (e.g. see Pezerat et al, 2021, OM), which allows to prevent an over dissipation by depth-induced breaking, especially in dissipative surf zone.
Please also include the following information:

  • Add any suggestions for a reviewer: Aron Roland, Ali Abdolali
  • Mention any labels that should be added: new feature
  • Are answer changes expected from this PR? Please describe the changes and the reason why in addition to which of the following labels would apply: out_grd change

Issue(s) addressed

None

Commit Message

Slope dependant breaking coefficient.

Check list

Testing

  • How were these changes tested? This new feature has been tested on regtest tp18 (Haas and Warner) and personnal configuration using unstructured grid.
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

…e depth-induced breaking source term following Pezerat et al. (2021) - OM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant