Inflow #50
Open
Inflow #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverted to mask from 0-360 (so, shifting by 180 degrees).
… to be called without specifying a land-mask file.
…found in input LSM file.
|
It looks like prior changes weren't merged yet. So, I checked out latest fresh code from the island_effect branch with weight.py island effect changes then added new changes for inflow and tried to push to master for review; of course the weight changes are flagged as new things to commit relative to master since they haven't been merged yet. Want me to re-do this wrt master once you merge, e.g.? Or is this ok for you? |
|
Hello @mjshaw1. This is perfect, thank you. Ahmad is out this week, so we are waiting on his review of the earlier pull request. Once that goes through, we will integrate this one. |
|
Hello. I was just wondering what the status is of this pull request. Are there questions I could help address? Thanks much, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes for handling of ERA5 quarter degree and ERA Interim t1279 Gaussian grid runoff for inflow generation.