-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
updated comments and news for CRAN update submission
- Loading branch information
Showing
2 changed files
with
33 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,35 @@ | ||
|
||
# Update to ensure `dplyr 0.8.0.` compatibility | ||
|
||
## Test environments | ||
* local Win10x64 R 3.5.1 | ||
* local MacOS 10.13.6 R 3.5.1 | ||
* TravisCI - Ubuntu 14.04.5 LTS R 3.5.1 | ||
* Win Builder R-devel (2018-11-16 r75619) | ||
* Win Builder R-release R 3.5.1 | ||
* local Win10x64 R 3.5.2 | ||
* local MacOS 10.13.6 R 3.5.2 | ||
* TravisCI - Ubuntu 14.04.5 LTS R 3.5.2 | ||
* Win Builder R-devel (2019-01-09 r75961) | ||
* Win Builder R-release R 3.5.2 | ||
* RHub Builder Debian Linux, R-devel, GCC | ||
* RHub Builder Fedora Linux, R-devel, clang, gfortran | ||
* Rhub Builder Ubuntu Linux 16.04 LTS, R-release, GCC | ||
* coverage -> 97% | ||
|
||
**There were no ERRORs, WARNINGs or NOTEs** | ||
## Test Results | ||
|
||
# Resubmission | ||
No errors or notes except for: | ||
|
||
*First word in description field in DESCRIPTION file starts with a small letter* | ||
Fixed | ||
**Installation errors for new suggested dependency `vidffr`** | ||
* RHub Builder Debian Linux, R-devel, GCC | ||
* RHub Builder Fedora Linux, R-devel, clang, gfortran | ||
--> since `vdiffr` is a tidyverse package I trust this not to be an issue in the future | ||
|
||
*Examples generating plots were wrapped in `\dontrun{if(interactive()){...}`* | ||
The `if(interactive())` was not necessary, however examples took a bit too long to execute, so they were wrapped in `\dontrun{}`. Adressed this now by allowing the first plot to render and then keeping the `\dontrun{}` wrapper for the plots that follow. | ||
**1 Note** | ||
Rhub Builder Ubuntu Linux 16.04 LTS, R-release, GCC | ||
|
||
``` | ||
Author field differs from that derived from Authors@R | ||
Author: ‘Bjoern Koneswarakantha [aut, cre] (<https://orcid.org/ 0000-0003-4585-7799>)’ | ||
Authors@R: ‘Bjoern Koneswarakantha [aut, cre] ( 0000-0003-4585-7799)’ | ||
``` | ||
--> Authors@R: person( "Bjoern", "Koneswarakantha", role = c("aut","cre"), email = "[email protected]", comment = c(ORCID = " 0000-0003-4585-7799") ) | ||
has not been changed since the latest submission to CRAN and is compliant with the format required [in CRAN checklist](ftp://cran.r-project.org/pub/R/web/packages/submission_checklist.html) | ||
|
||
*No citation of method in description field* | ||
Citation was added. | ||
# This package does not have any reverse dependencies |