Skip to content

Commit

Permalink
updated comments and news for CRAN update submission
Browse files Browse the repository at this point in the history
  • Loading branch information
erblast committed Jan 14, 2019
1 parent cf72b93 commit d27d030
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 16 deletions.
9 changes: 6 additions & 3 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@

# Version: 0.1.8, released 20190113
- `dplyr 7.8.0` compatibility
- `vdiffr` checks for plots
# Version: 0.1.8, submitted to CRAN 20190115
- `dplyr 0.8.0.` compatibility
- `vdiffr` is now used to test plots and added as a suggested dependency
- `manip_bin_numerics()` accepts c('median', 'mean', 'cuts', 'min_max') as bin_labels
argument which will be converted to bin label.
- `alluvial_wide()` and `alluvial_long()` do not crash anymore when dataframes are grouped

# 20181812 0.1.7
CRAN released

# 20181118
CRAN submission

Expand Down
40 changes: 27 additions & 13 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,35 @@

# Update to ensure `dplyr 0.8.0.` compatibility

## Test environments
* local Win10x64 R 3.5.1
* local MacOS 10.13.6 R 3.5.1
* TravisCI - Ubuntu 14.04.5 LTS R 3.5.1
* Win Builder R-devel (2018-11-16 r75619)
* Win Builder R-release R 3.5.1
* local Win10x64 R 3.5.2
* local MacOS 10.13.6 R 3.5.2
* TravisCI - Ubuntu 14.04.5 LTS R 3.5.2
* Win Builder R-devel (2019-01-09 r75961)
* Win Builder R-release R 3.5.2
* RHub Builder Debian Linux, R-devel, GCC
* RHub Builder Fedora Linux, R-devel, clang, gfortran
* Rhub Builder Ubuntu Linux 16.04 LTS, R-release, GCC
* coverage -> 97%

**There were no ERRORs, WARNINGs or NOTEs**
## Test Results

# Resubmission
No errors or notes except for:

*First word in description field in DESCRIPTION file starts with a small letter*
Fixed
**Installation errors for new suggested dependency `vidffr`**
* RHub Builder Debian Linux, R-devel, GCC
* RHub Builder Fedora Linux, R-devel, clang, gfortran
--> since `vdiffr` is a tidyverse package I trust this not to be an issue in the future

*Examples generating plots were wrapped in `\dontrun{if(interactive()){...}`*
The `if(interactive())` was not necessary, however examples took a bit too long to execute, so they were wrapped in `\dontrun{}`. Adressed this now by allowing the first plot to render and then keeping the `\dontrun{}` wrapper for the plots that follow.
**1 Note**
Rhub Builder Ubuntu Linux 16.04 LTS, R-release, GCC

```
Author field differs from that derived from Authors@R
Author: ‘Bjoern Koneswarakantha [aut, cre] (<https://orcid.org/ 0000-0003-4585-7799>)’
Authors@R: ‘Bjoern Koneswarakantha [aut, cre] ( 0000-0003-4585-7799)’
```
--> Authors@R: person( "Bjoern", "Koneswarakantha", role = c("aut","cre"), email = "[email protected]", comment = c(ORCID = " 0000-0003-4585-7799") )
has not been changed since the latest submission to CRAN and is compliant with the format required [in CRAN checklist](ftp://cran.r-project.org/pub/R/web/packages/submission_checklist.html)

*No citation of method in description field*
Citation was added.
# This package does not have any reverse dependencies

0 comments on commit d27d030

Please sign in to comment.