fix: StrictMode behaviour #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Vladimir-Kokin
commented
Jul 4, 2024
•
Vladimir-Kokin
commented
- fix StrictMode; (See [NGRM] - SyncLogViewer is not working if wrapped with React.StrictMode component #2110)
- fix missed props.domain in WLV
- fix primaryAxes notification processing (TVD/MD switch)
- add onDeleteController callback to SyncLogViewer props ([NGRM] - enhance WLV and SLV controller mechanism #2053 (comment))
Vladimir-Kokin
added
bug
mirisb
reviewed
Jul 4, 2024
mirisb
approved these changes
Jul 4, 2024
w1nklr
requested changes
Jul 4, 2024
typescript/packages/well-log-viewer/src/SyncLogViewer.stories.tsx
Outdated
Show resolved
Hide resolved
typescript/packages/well-log-viewer/src/SyncLogViewer.stories.tsx
Outdated
Show resolved
Hide resolved
typescript/packages/well-log-viewer/src/components/WellLogView.tsx
Outdated
Show resolved
Hide resolved
w1nklr
requested changes
Jul 5, 2024
typescript/packages/well-log-viewer/src/SyncLogViewer.stories.tsx
Outdated
Show resolved
Hide resolved
w1nklr
approved these changes
Jul 11, 2024
hkfb
pushed a commit
that referenced
this pull request
Jul 18, 2024
# [1.11.0](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@1.11.0) (2024-07-18) ### Bug Fixes * bump @equinor/videx-wellog from 0.9.4 to 0.10.0 in /typescript ([#2120](#2120)) ([614bc81](614bc81)) * bump @turf/simplify from 6.5.0 to 7.0.0 in /typescript ([#2144](#2144)) ([888d147](888d147)), closes [/github.com/Turfjs/turf/blob/master/CHANGELOG.md#700](https://github.com//github.com/Turfjs/turf/blob/master/CHANGELOG.md/issues/700) [#2158](#2158) [#2237](#2237) [#2177](#2177) [#2173](#2173) [#2393](https://github.com/equinor/webviz-subsurface-components/issues/2393) [#2166](#2166) [#2183](#2183) [#2106](#2106) [#2106](#2106) [#2247](#2247) [#2247](#2247) [#2247](#2247) [#2613](https://github.com/equinor/webviz-subsurface-components/issues/2613) [#1896](#1896) [#2217](#2217) [#2231](#2231) [#1893](#1893) [#2033](#2033) [#2338](https://github.com/equinor/webviz-subsurface-components/issues/2338) [#2415](https://github.com/equinor/webviz-subsurface-components/issues/2415) [#1450](#1450) [#2149](#2149) [#2323](#2323) [#2142](#2142) [#2316](#2316) [#2345](https://github.com/equinor/webviz-subsurface-components/issues/2345) [#2178](#2178) [#2168](#2168) [#2174](#2174) [#2182](#2182) [#2171](#2171) [#2171](#2171) [#2167](#2167) [#2134](#2134) [#2169](#2169) [#2195](#2195) [#2216](#2216) [#2227](#2227) [#2172](#2172) [#2475](https://github.com/equinor/webviz-subsurface-components/issues/2475) [#2504](https://github.com/equinor/webviz-subsurface-components/issues/2504) [#2524](https://github.com/equinor/webviz-subsurface-components/issues/2524) [#2609](https://github.com/equinor/webviz-subsurface-components/issues/2609) [#2607](https://github.com/equinor/webviz-subsurface-components/issues/2607) [#2603](https://github.com/equinor/webviz-subsurface-components/issues/2603) [#2599](https://github.com/equinor/webviz-subsurface-components/issues/2599) [#2565](https://github.com/equinor/webviz-subsurface-components/issues/2565) [#2576](https://github.com/equinor/webviz-subsurface-components/issues/2576) [#2572](https://github.com/equinor/webviz-subsurface-components/issues/2572) [#2571](https://github.com/equinor/webviz-subsurface-components/issues/2571) * bump ajv from 8.14.0 to 8.16.0 in /typescript ([#2138](#2138)) ([3f02100](3f02100)), closes [ajv-validator/ajv#2444](ajv-validator/ajv#2444) [ajv-validator/ajv#2415](ajv-validator/ajv#2415) [ajv-validator/ajv#2442](ajv-validator/ajv#2442) [ajv-validator/ajv#2415](ajv-validator/ajv#2415) [#2444](https://github.com/equinor/webviz-subsurface-components/issues/2444) [#2442](https://github.com/equinor/webviz-subsurface-components/issues/2442) [#2415](https://github.com/equinor/webviz-subsurface-components/issues/2415) * bump mathjs from 12.4.2 to 13.0.0 in /typescript ([#2124](#2124)) ([caae3f2](caae3f2)), closes [#3223](https://github.com/equinor/webviz-subsurface-components/issues/3223) [#3139](https://github.com/equinor/webviz-subsurface-components/issues/3139) [#2838](https://github.com/equinor/webviz-subsurface-components/issues/2838) [#3152](https://github.com/equinor/webviz-subsurface-components/issues/3152) [#2838](https://github.com/equinor/webviz-subsurface-components/issues/2838) [rawify/Fraction.js#68](rawify/Fraction.js#68) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#1240](#1240) [#3189](https://github.com/equinor/webviz-subsurface-components/issues/3189) [#3197](https://github.com/equinor/webviz-subsurface-components/issues/3197) [#3198](https://github.com/equinor/webviz-subsurface-components/issues/3198) * Crash Removing Well Log in SLV ([#2122](#2122)) ([4139860](4139860)), closes [#2114](#2114) * Property "setControllerDefaultZoom" does not exist on type "WellLogController" ([#2136](#2136)) ([a2390e2](a2390e2)) * semantic release not publishing ([#2160](#2160)) ([235c558](235c558)) * semantic release not publishing ([#2164](#2164)) ([9878239](9878239)) * StrictMode behaviour ([#2139](#2139)) ([807fff4](807fff4)), closes [#2110](#2110) [/github.com//issues/2053#issuecomment-2194025734](https://github.com//github.com/equinor/webviz-subsurface-components/issues/2053/issues/issuecomment-2194025734) ### Features * color function ([#2054](#2054)) ([#2152](#2152)) ([36b85bb](36b85bb))
|
🎉 This issue has been resolved in version [email protected] 🎉 The release is available on GitHub release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.