Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add action to update smoke tests. #1975

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

nilscb
Copy link
Collaborator

@nilscb nilscb commented Mar 19, 2024

No description provided.

@nilscb nilscb changed the title Add action to updates smoke tests. feat: Add action to updates smoke tests. Mar 19, 2024
@w1nklr
Copy link
Collaborator

w1nklr commented Mar 19, 2024

I don't understand the logic !?

We want to be able to run the update on our local machine, to update the reference images.
What do you want to achieve with this new github check ?

@nilscb
Copy link
Collaborator Author

nilscb commented Mar 19, 2024

Updating the smoke tests does not work on windows. We want a PR to be automatically created with updated tests (if necessary): One may then merge this PR with the original to have updated tests.
This is not finished. Håvard will help me to conclude this.

@nilscb nilscb marked this pull request as draft March 19, 2024 14:35
@nilscb nilscb marked this pull request as ready for review March 20, 2024 12:35
.github/workflows/typescript.yml Outdated Show resolved Hide resolved
.github/workflows/typescript.yml Outdated Show resolved Hide resolved
- name: Create Pull Request
id: cpr
uses: peter-evans/create-pull-request@5a6b15373e5788c38d83296b674ad5abea28085c
if: github.event_name == 'push' && (github.ref != 'refs/heads/master' || contains(github.event.head_commit.message, '[deploy test]'))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure what to make of this, but it looks like the event_name triggered is pull_request and not push

##[debug]Evaluating condition for step: 'Create Pull Request'
##[debug]Evaluating: (success() && (github.event_name == 'push') && ((github.ref != 'refs/heads/master') || contains(github.event.head_commit.message, '[deploy test]')))
##[debug]Evaluating And:
##[debug]..Evaluating success:
##[debug]..=> true
##[debug]..Evaluating Equal:
##[debug]....Evaluating Index:
##[debug]......Evaluating github:
##[debug]......=> Object
##[debug]......Evaluating String:
##[debug]......=> 'event_name'
##[debug]....=> 'pull_request'
##[debug]....Evaluating String:
##[debug]....=> 'push'
##[debug]..=> false
##[debug]=> false
##[debug]Expanded: (true && ('pull_request' == 'push') && ((github['ref'] != 'refs/heads/master') || contains(github['event']['head_commit']['message'], '[deploy test]')))

@hkfb hkfb changed the title feat: Add action to updates smoke tests. ci: Add action to update smoke tests. Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants