Mark browser-tests for conditional executions #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for your contribution! We are looking at your PR now, but we are currently coming back from vacation. Don't be afraid to reach out if you have any questions :) |
eivindjahren
requested changes
Jul 29, 2024
eivindjahren
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #446
Approach
Following the issue's comment made by @kwinkunks
"But we could mark tests requiring the driver, however, so that if situations like this happen again, we can easily turn off the tests temporarily.", the approach went on marking the tests that requires dash / Selenium as "browser-test", which can be skipped with the command "pytest --skip-browser-tests".
Pre review checklist