Fix index for clicking on observation #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added a bunch of inline comments for this one, please feel free to take offense in that : ) |
valentin-krasontovitsch
force-pushed
the
fix-obs-index-369
branch
from
bab59ff
to
836f6b5
Compare
oysteoh
reviewed
Aug 18, 2022
valentin-krasontovitsch
force-pushed
the
fix-obs-index-369
branch
from
836f6b5
to
17e1d0a
Compare
oysteoh
approved these changes
Aug 18, 2022
valentin-krasontovitsch
force-pushed
the
fix-obs-index-369
branch
from
17e1d0a
to
71a49e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #369
Approach
We check whether the click was right on an observation, and do a reverse lookup of the clicked x value in the response axis - the previously used clicked index for an observation point refers to the observation axis, which is potentially shorter than the response axis.
Pre review checklist