Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indent issue #754

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Fix indent issue #754

merged 2 commits into from
Oct 15, 2024

Conversation

alifbe
Copy link
Collaborator

@alifbe alifbe commented Oct 14, 2024

Fix a subtle issue when building documentation. It gives error message Unexpected indentation. From what I can see, it doesn't seems to change the output.

https://github.com/equinor/subscript/actions/runs/11283815471/job/31383917419#step:13:228

As an addition, remove the * since it doesn't seems to be formatted properly in documentation.

We could consider using -W option to turn warning into error.

Also fix the issue due to mypy upgrading to 1.12

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.91%. Comparing base (190e314) to head (1245d95).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #754   +/-   ##
=======================================
  Coverage   85.91%   85.91%           
=======================================
  Files          52       52           
  Lines        7307     7307           
=======================================
  Hits         6278     6278           
  Misses       1029     1029           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alifbe alifbe requested review from a team and oddvarlia October 14, 2024 22:42
@alifbe alifbe marked this pull request as ready for review October 14, 2024 22:42
@alifbe alifbe merged commit 0f348be into main Oct 15, 2024
6 checks passed
@alifbe alifbe deleted the fix-indent-issue branch October 15, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants