Fixed input file paths in template for rms script to be generated #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #747 +/- ##
==========================================
+ Coverage 85.03% 85.87% +0.84%
==========================================
Files 52 52
Lines 7229 7229
==========================================
+ Hits 6147 6208 +61
+ Misses 1082 1021 -61 ☔ View full report in Codecov by Sentry. |
|
Also fixed test_field_statistics.py by fixing input to a subprocess running field_statistics.py |
alifbe
reviewed
Oct 2, 2024
tests/test_field_statistics.py
Outdated
|
|
||
| # Run the main script as a subprocess,but first clean up | ||
| # result directory to be sure this test does not re-use | ||
| # previous results from previous tests | ||
| remove_file_path = result_path / Path("ertbox--*.roff") |
There was a problem hiding this comment.
I don't think this is needed. tmp_path will always be a new path every time the test is initiated.
There was a problem hiding this comment.
OK, I can remove the subprocess to clean up then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still some field paths in the rms script generated by field_statistics.py that need to be fixed.