feat: onboard apps with context #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new component called ContextIndicator to the AgStyle file in the portal-administration application. The ContextIndicator component is a styled span element that displays a colored circle based on the value of the 'active' prop. If the prop is set to 'true', the background color of the circle is set to the warning color defined in the design tokens. Otherwise, the background color is set to 'none'. This component is used for indicating the active state of a context in the application.
…lApplication types This commit adds the properties isGlobal and isContextual to the PortalApp and PortalApplication types in the index.ts file. These properties indicate whether an app or application is global or contextual. The isGlobal property is added to the PortalApp type, while both properties are added to the PortalApplication type. This change allows for better categorization and management of apps and applications in the portal-administration application.
The ShowConfigPage component in the Portal folder had some unused imports that were causing unnecessary overhead. This commit removes the unused imports to improve code cleanliness and performance.
The AddContext component in the OnboardedContexts folder was updated to improve the user experience. The component now displays "Add Context" instead of "Add Context Type" to provide clearer instructions. Additionally, the InfoPopover title was changed to "Add Context" to match the updated component name. These changes enhance the usability of the AddContext feature in the portal-administration application.
🦋 Changeset detectedLatest commit: a0dcdec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Noggling
changed the title
EdwardBrunton
approved these changes
Sep 24, 2024
| activateSelectedWithContext: VoidFunction; | ||
| }; | ||
|
|
||
| export const ActivateSelectedWithContextButton = ({ | ||
| selection, | ||
| activateSelectedWithContext, | ||
| }: ActivateSelectedWithContextButtonProps) => { | ||
| const isActive = selection.some((a) => a.isActive); | ||
| const isActive = selection.some((a) => !a.isActive) && selection.length < 2; |
| import { useResizeObserver } from '../../hooks/use-resise-observer'; | ||
| import { AgStyles } from '../AgStyle'; | ||
| import { AddContext } from '../OnboardedContexts/AddContext'; | ||
| import { Loading } from '../Loading'; | ||
|
|
||
| const Style = { |
There was a problem hiding this comment.
Consider moving this to a separate file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please select version type the purposed change:
External Relations
Changeset
The portal administration now also allows onboarding applications with a specific context.