Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change remove-global-app to be remove-app #751

Merged
merged 8 commits into from
Sep 18, 2024

Conversation

Jossilainen
Copy link
Contributor

Description

The Remove app endpoint now removes an app from a portal even if the app is contextual or global.

  • PR title and description are to the point and understandable
  • I have performed a self-review of my own code'

Please select version type the purposed change:

  • major
  • minor
  • patch
  • none

External Relations

  • database migration

Changeset

Delete app now removes an app from a portal even if the app is contextual or global

@Jossilainen Jossilainen self-assigned this Sep 17, 2024
@Jossilainen Jossilainen requested a review from a team as a code owner September 17, 2024 12:43
Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: b13f382

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fusion-project-portal Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Jossilainen Jossilainen linked an issue Sep 17, 2024 that may be closed by this pull request
Copy link
Member

@kjetilhau kjetilhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide an integration test for deleting an app for multiple contexts?

@Jossilainen Jossilainen merged commit 0871598 into main Sep 18, 2024
7 checks passed
@Jossilainen Jossilainen deleted the feat/remove-app-from-portal branch September 18, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RemoveGlobalApp should be refactored to be RemoveApp
2 participants