Switch to Erts newer plugin system #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
force-pushed
the
new_ert_plugin
branch
2 times, most recently
from
4c49e43
to
ad5795b
Compare
|
Hehe still a draft :) just ping when done! |
|
oh, it is done, was just missing a final in the commit, now in place. Is the plugin system tested in CI? |
Yes we are testing it! You'll find it under "tests/test_integration" if you want to have a look |
|
btw we have this commit prefix system, would you add the prefix |
Avoids DeprecationWarnings. Drop falling back to ert_shared, which is no longer around.
berland
force-pushed
the
new_ert_plugin
branch
from
ad5795b
to
82c1b2e
Compare
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids DeprecationWarnings.