FIX: Give Optionals a default value #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
commented
Sep 26, 2024
src/fmu/dataio/_model/fields.py
Outdated
Comment on lines
106
to
108
| checksum_md5: Optional[str] = Field( | ||
| default=None, examples=["kjhsdfvsdlfk23knerknvk23"] | ||
| ) |
There was a problem hiding this comment.
A test requires that validation cannot occur without checksum, still listed as Optional. Is this a backward compatibility thing patch-handled in Sumo?
mferrera
force-pushed
the
ensure-optionals-have-defaults
branch
from
bb5b7a0
to
b2d2801
Compare
mferrera
commented
Sep 26, 2024
mferrera
force-pushed
the
ensure-optionals-have-defaults
branch
from
b2d2801
to
b3f3818
Compare
tnatt
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #814
Resolves #815
I still have a bit uncertainty about some fields. In some cases we give optional lists a default value of an empty list, in some cases it's
null.A few instances I added the
Fieldor sorted the keyword arguments to it to make the default show first.I'm working on a test that will run through all the models and fail if an optional doesn't provide a default value... but figured I can put this up before that is working.