FIX: Give Optionals a default value #818
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #814
Resolves #815
I still have a bit uncertainty about some fields. In some cases we give optional lists a default value of an empty list, in some cases it's
null
.A few instances I added the
Field
or sorted the keyword arguments to it to make the default show first.I'm working on a test that will run through all the models and fail if an optional doesn't provide a default value... but figured I can put this up before that is working.