MAINT: Refactor to remove the _usefmtflag #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnatt
commented
Sep 24, 2024
| @@ -86,9 +86,12 @@ def export_metadata_file( | |||
| def export_file( | |||
| obj: types.Inferrable, | |||
| filename: Path, | |||
| flag: str | None = None, | |||
| fmt: str = "", | |||
There was a problem hiding this comment.
Renamed to fmt to make it more clear what it is
tnatt
requested review from
mferrera,
slangeveld and
jcrivenaes
and removed request for
mferrera
tnatt
commented
Sep 24, 2024
| @@ -942,7 +931,7 @@ def export( | |||
| outfile = Path(metadata["file"]["absolute_path"]) | |||
| metafile = outfile.parent / f".{outfile.name}.yml" | |||
|
|
|||
| export_file(obj, outfile, flag=self._usefmtflag) | |||
| export_file(obj, outfile, fmt=metadata["data"].get("format", "")) | |||
There was a problem hiding this comment.
data.format in the metadata is populated by the objdata.fmt
mferrera
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to refactor and remove the internal variable
_usefmtflagby picking up this format information from theobjdata.fmtinsteadThis
_usefmtflagvariable is used to indicate if a point/polygon has "xtgeo" in the format string (then no renaming of column names should occur on the dataframe). It was necessary to run theself._update_fmt_flag()in order to make sure the state of this variable was set correctly. This function is here removed.