Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Remove unused volumetrics and inplace_volumes contents. #637

Conversation

perolavsvendsen
Copy link
Member

Solve #378 (again)

I don't think these need to be deprecated, as fmu-dataio will currently not work if one attempts to export either inplace_volumes or volumetrics.

So just deleting them.

@perolavsvendsen perolavsvendsen force-pushed the 378-remove-volumetrics-inplace_volumes branch from e559b25 to 2119380 Compare April 26, 2024 12:42
Copy link
Collaborator

@jcrivenaes jcrivenaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@perolavsvendsen perolavsvendsen merged commit 771ba28 into equinor:main Apr 29, 2024
13 checks passed
@perolavsvendsen perolavsvendsen deleted the 378-remove-volumetrics-inplace_volumes branch April 29, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants