Initialize ExportData with tmp config obj from AggregatedData.

[perolavsvendsen]

Solve #625 and silence warning about erroneous config. It is spamming the logs on our service, and the text is misleading (see issue).

[perolavsvendsen]

Ref options listed in the issue, I am not convinced that this is the best way of solving this. It feels a bit like duct tape. Open for opinions and suggestions.

[tnatt]

yes, it feels a bit hacky which is why I took it away recently 🙂 but I see the problem with logs being spammed. This AggregatedData needs a bit of attention later, but for now I guess taking this fake config back could be an option..

Or probably better, rewrite:

fmu-dataio/src/fmu/dataio/dataio.py

Line 475 in bec7647

self._config_is_valid = global_configuration.is_valid(self.config)

to:
self._config_is_valid = global_configuration.is_valid(self.config) if self.config else False

That will silence the pydantic warnings, and there is no need of validating the config if it is not given anyway 👍

[tnatt]

And then we move the warning regarding missing config and that the metadata will be empty to when the user try to create metadata instead. So that when using this AggregatedData, the users are not exposed to it.

[perolavsvendsen]

fmu-dataio/src/fmu/dataio/dataio.py

Line 475 in bec7647

self._config_is_valid = global_configuration.is_valid(self.config)

to: self._config_is_valid = global_configuration.is_valid(self.config) if self.config else False

That will silence the pydantic warnings, and there is no need of validating the config if it is not given anyway 👍

Yes, that looks potentially more elegant. But are there unwanted side-effects? Wouldn't this fail to warn if ExportData is attempted initialized without config in other contexts? (Do we want that?)

Edit: This will then fail to trigger:

fmu-dataio/tests/test_units/test_dataio.py

Line 57 in bec7647

with pytest.warns(UserWarning, match=pydantic_warning()):

[tnatt]

fmu-dataio/src/fmu/dataio/dataio.py

Line 475 in bec7647

self._config_is_valid = global_configuration.is_valid(self.config)

to: self._config_is_valid = global_configuration.is_valid(self.config) if self.config else False
That will silence the pydantic warnings, and there is no need of validating the config if it is not given anyway 👍

Yes, that looks potentially more elegant. But are there unwanted side-effects? Wouldn't this fail to warn if ExportData is attempted initialized without config in other contexts? (Do we want that?)

Hm, maybe... And eventually we are moving towards requiring a valid config as input, so probably making the fake config here is the best solution for now 👍 and then we'll address it later when we give some attention to this class 🙂

[perolavsvendsen]

Ah, did not see the last comment until now. Tried the (previously) suggested change. Can revert back if we liked the first one better. #dontmerge

[perolavsvendsen]

Which one do we want? First or second...?

[tnatt]

Which one do we want? First or second...?

I say first!

[perolavsvendsen]

Which one do we want? First or second...?

I say first!

Backtracked, now using fake config again ✅

[perolavsvendsen]

@tnatt happy? OK to merge...?

[tnatt]

@tnatt happy? OK to merge...?

Yes 👍