Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Move validation of workflow key #590

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Apr 10, 2024

PR to move the validation of the workflow key outside of the FmuProvider, and utilizing existing pydantic model for the validation.

Copy link
Member

@perolavsvendsen perolavsvendsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Not a breaking change (still allow dict as input), but deprecate this possibility with a warnings sounds sensible.

@tnatt tnatt merged commit f0a91df into equinor:main Apr 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants