Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Change to correct model key format in tests #587

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Apr 9, 2024

The model key format in the global_configuration is a dictionary with required keys name and revision. Update tests to reflect this.

Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit surprised mypy was not complaining about this

@mferrera
Copy link
Collaborator

mferrera commented Apr 9, 2024

Ah nevermind, of course it didn't... dict

@tnatt tnatt merged commit a8ae9b3 into equinor:main Apr 10, 2024
13 checks passed
@tnatt tnatt deleted the model_format branch April 10, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants