ENH: Set fmu_context from env variables if not explicitly given #586
Conversation
| assert edata._fmurun is False | ||
| assert edata.fmu_context == FmuContext.NON_FMU | ||
|
|
||
|
|
There was a problem hiding this comment.
Possibly just OCD, but missing one combination in this pattern?
e.g.
assert FmuEnv.RUNPATH.value is not None
assert FmuEnv.EXPERIMENT_ID.value is None(Probably just OCD)
There was a problem hiding this comment.
Could be useful if we at some point use the presence of one of these as a condition to check for the presence of the next.
There was a problem hiding this comment.
The PR itself is good I think 👍
The whole topic is a bit sketchy, however. I.e. the whole concept/definition of the context (called "stage" in the code) is in need of some sort of refinement. (But that's not the point nor topic of this PR!)
One comment on the tests, which may or may not be relevant. But if the definition of one (in the future) is a condition for testing the definition of the next, it might be smart to have a test like the one suggested. Possibly...
PR to change from having
relizationas defaultfmu_context,to using environment variables from ERT to set the fmu_context value if not explicitly given.Closes #585