CLN: Create ExistingDataProvider directly #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
force-pushed
the
split-existing
branch
2 times, most recently
from
be54222
to
a2d44db
Compare
mferrera
force-pushed
the
split-existing
branch
from
a2d44db
to
eceb1e4
Compare
Rather than keeping existing metadata as an optional argument for all data providers, if existing metadata exists just create the class directly from it.
mferrera
force-pushed
the
split-existing
branch
from
eceb1e4
to
28aad46
Compare
tnatt
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than keeping existing metadata as an optional argument for all data providers, if existing metadata exists just create the class directly from it.